also removeExtensionFromRelativeAmdId in UMD finaliser #3872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjenkinson
force-pushed
the
remove-extension-amd-umd
branch
from
a097370 to
f271160
Compare
tjenkinson
force-pushed
the
remove-extension-amd-umd
branch
from
f271160 to
3bcd1cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #3872 +/- ##
=======================================
Coverage 97.07% 97.07%
=======================================
Files 184 185 +1
Lines 6523 6523
Branches 1889 1889
=======================================
Hits 6332 6332
Misses 101 101
Partials 90 90
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
Description
I noticed in the UMD finialiser the AMD ids are not run through
removeExtensionFromRelativeAmdIdwhen in the AMD one they are.Should't they work the same way?