Skip to content

fix: set header to empty string if undefined #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjamincanac merged 1 commit into from
Nov 6, 2020
Merged

fix: set header to empty string if undefined #620

benjamincanac merged 1 commit into from
Nov 6, 2020

Conversation

@atinux
Copy link
Member

@atinux atinux commented Nov 5, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #136

@atinux atinux changed the title fix: set header to empty array fix: set header to empty string if undefined Nov 5, 2020
@atinux atinux requested a review from benjamincanac November 5, 2020 11:20
@atinux atinux mentioned this pull request Nov 6, 2020
Closed
@benjamincanac benjamincanac merged commit 5bffdf1 into dev Nov 6, 2020
@benjamincanac benjamincanac deleted the fix/socket-upgrade branch November 6, 2020 09:57
@atinux atinux mentioned this pull request Nov 19, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Websocket error using alternative server framework

3 participants

@atinux @benjamincanac