Skip to content

chore: prompt maintainer to quit make watch before publish #12357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JLHwung merged 2 commits into from
Nov 14, 2020
Merged

chore: prompt maintainer to quit make watch before publish #12357

JLHwung merged 2 commits into from
Nov 14, 2020

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 13, 2020 •
edited by gitpod-io bot
Loading

Q                       A
License MIT

Sometimes maintainers could forgot to quit make watch when doing make publish, this will render duplicate files shipped in artifacts, e.g. @babel/parser: https://unpkg.com/browse/@babel/[email protected]/lib/

This PR adds a prompt before make publish is run.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Nov 13, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented Nov 13, 2020 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/32625/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 13, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f47e4c6:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

nicolo-ribaudo
nicolo-ribaudo reviewed Nov 13, 2020
View reviewed changes
nicolo-ribaudo
nicolo-ribaudo approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😄

@JLHwung JLHwung merged commit cff0d7c into babel:main Nov 14, 2020
@JLHwung JLHwung deleted the prompt-checklist-before-publish branch November 14, 2020 13:23
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

+1 more reviewer

@snitin315 snitin315 snitin315 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JLHwung @babel-bot @existentialism @nicolo-ribaudo @snitin315