Skip to content

Fix syntax error for getter and setter with typescript and estree plugin #12333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolo-ribaudo merged 1 commit into from
Nov 9, 2020
Merged

Fix syntax error for getter and setter with typescript and estree plugin #12333

nicolo-ribaudo merged 1 commit into from
Nov 9, 2020

Conversation

@sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Nov 8, 2020 •
edited by gitpod-io bot
Loading

Q                       A
Fixed Issues? Fixes #12255
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? N
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented Nov 8, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/32007/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5202356:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo added area: estree area: typescript pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Nov 8, 2020
kaicataldo
kaicataldo approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nicolo-ribaudo nicolo-ribaudo merged commit ad8a4d6 into babel:main Nov 9, 2020
@sosukesuzuki sosukesuzuki deleted the fix-12255 branch November 9, 2020 07:41
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees

No one assigned

Labels

area: estree area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError is thrown for setter with estree plugin and typescript plugin

4 participants

@sosukesuzuki @babel-bot @nicolo-ribaudo @kaicataldo