Skip to content

fix axios.delete ignores config.data #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jasonsaayman merged 2 commits into from
Oct 1, 2020
Merged

fix axios.delete ignores config.data #3282

jasonsaayman merged 2 commits into from
Oct 1, 2020
+13 −1

Conversation

@chinesedfan
Copy link
Contributor

@chinesedfan chinesedfan commented Sep 12, 2020

Fixes #3220. As explained in #3220 (comment).

@chinesedfan chinesedfan mentioned this pull request Sep 12, 2020
Closed
@wopian wopian mentioned this pull request Sep 12, 2020
Merged
1 task
@cuongdevjs
Copy link

cuongdevjs commented Sep 16, 2020

How long this pr merged and release?

@tobias-grasse tobias-grasse mentioned this pull request Sep 17, 2020
Closed
@ngajhede
Copy link

ngajhede commented Sep 18, 2020 •
edited
Loading

Yes please. This is currently breaking parts of our application.

A temporary solution is to use axios.request:
axios.request({data, url, method: 'delete'});

jasonsaayman
jasonsaayman reviewed Sep 21, 2020
View reviewed changes
Copy link
Member

@jasonsaayman jasonsaayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I think this will help us with potentially breaking changes in the future.

@ngajhede ngajhede mentioned this pull request Sep 30, 2020
Closed
jasonsaayman
jasonsaayman reviewed Oct 1, 2020
View reviewed changes
Copy link
Member

@jasonsaayman jasonsaayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jasonsaayman jasonsaayman merged commit fa36737 into axios:master Oct 1, 2020
@DanielIndie95
Copy link

DanielIndie95 commented Oct 6, 2020

@jasonsaayman why isnt that released yet? As I can see that the latest version is still 0.20.0

@jmsv jmsv mentioned this pull request Oct 11, 2020
Closed
@MwumLi
Copy link

MwumLi commented Oct 12, 2020

@jasonsaayman why isnt that released yet? npm version not match github tag

@lifesboy
Copy link

lifesboy commented Oct 14, 2020

When will this version be released, please?

@pholleyad
Copy link

pholleyad commented Oct 15, 2020

Adding another request for this to be released as well. Thanks @ngajhede for the workaround!

@jasonsaayman
Copy link
Member

jasonsaayman commented Oct 16, 2020

Hi All,

I am not able to do the release, only Emily can, I have spoken to her and I think we should see the release over the weekend.

Thanks

@nrayburn-tech nrayburn-tech mentioned this pull request Oct 18, 2020
Closed
@rlightner
Copy link

rlightner commented Oct 21, 2020

@jasonsaayman any word from @emilyemorehouse?

@jasonsaayman
Copy link
Member

jasonsaayman commented Oct 22, 2020

I have asked again today to see when the release will happen, will update this thread as soon as I know whats going on.

@jasonsaayman
Copy link
Member

jasonsaayman commented Oct 23, 2020

Hi,

Version 0.21.0 has been released 🎉 please use that and let us know if that solves your issue.

Thanks

This was referenced Jan 5, 2021
Open
Open
Closed
Merged
Merged
This was referenced Mar 5, 2021
Merged
Open
This was referenced Mar 18, 2021
Open
Closed
Open
Closed
Merged
Open
Open
Merged
Closed
Open
Merged
Merged
Closed
Open
Merged
Merged
Open
Merged
Merged
Merged
Merged
Open
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 28, 2021
Closed
@heliocorreia heliocorreia mentioned this pull request Oct 13, 2021
Merged
mbargiel pushed a commit to mbargiel/axios that referenced this pull request Jan 27, 2022
@chinesedfan @jasonsaayman
fix axios.delete ignores config.data (axios#3282)
b9b085e 
Co-authored-by: Jay <[email protected]>
@Omrisnyk Omrisnyk mentioned this pull request Dec 20, 2023
Open
@Omrisnyk Omrisnyk mentioned this pull request Jan 2, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Mar 16, 2024
Open
This was referenced Oct 27, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonsaayman jasonsaayman jasonsaayman left review comments

+1 more reviewer

@cuongdevjs cuongdevjs cuongdevjs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Axios does not use data from config when making DELETE request

9 participants

@chinesedfan @cuongdevjs @ngajhede @DanielIndie95 @MwumLi @lifesboy @pholleyad @jasonsaayman @rlightner