gavin
/
bc
2
3
Fork 4
Code Issues Pull Requests Releases 128 Wiki Activity

Avoid clobbering r variable in Bessel function #7

Merged
gavin merged 1 commits from mcf/bc:bessel into master 2020-11-21 14:44:54 -07:00
Conversation 3 Commits 1 Files Changed 1 +1 -1
mcf commented 2020-11-20 14:29:14 -07:00
Contributor
Copy Link

The j function uses r to accumulate its result, but did not
declare it with auto, causing the caller's value to be clobbered.

To fix this, declare r as auto to make it a local variable.

The `j` function uses `r` to accumulate its result, but did not declare it with auto, causing the caller's value to be clobbered. To fix this, declare `r` as auto to make it a local variable.
gavin merged commit 021527d2bc into master 2020-11-21 14:44:53 -07:00
gavin commented 2020-11-21 14:45:22 -07:00
Owner
Copy Link

Obvious bug is obvious, and obvious fix is obvious. I will put out a release very soon. Thank you!

Obvious bug is obvious, and obvious fix is obvious. I will put out a release very soon. Thank you!
gavin commented 2020-11-21 14:46:10 -07:00
Owner
Copy Link

Sorry, I didn't mean that what you did wasn't valuable. I obviously didn't catch it.

What I meant is that is was obvious that your fix was good.

Words...

Sorry, I didn't mean that what you did wasn't valuable. I obviously didn't catch it. What I meant is that is was obvious that your fix was good. Words...
gavin commented 2020-11-26 09:13:23 -07:00
Owner
Copy Link

Release is out!

Release is out!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gavin/bc#7
No description provided.
Delete Branch "mcf/bc:bessel"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?