-
-
Save leonderijke/c5cf7c5b2e424c0061d2 to your computer and use it in GitHub Desktop.
| /** | |
| * SVG Fixer | |
| * | |
| * Fixes references to inline SVG elements when the <base> tag is in use. | |
| * Firefox won't display SVG icons referenced with | |
| * `<svg><use xlink:href="#id-of-icon-def"></use></svg>` when the <base> tag is on the page. | |
| * | |
| * More info: | |
| * - http://stackoverflow.com/a/18265336/796152 | |
| * - http://www.w3.org/TR/SVG/linking.html | |
| * | |
| * One would think that setting the `xml:base` attribute fixes things, | |
| * but that is being removed from the platform: https://code.google.com/p/chromium/issues/detail?id=341854 | |
| */ | |
| (function(document, window) { | |
| "use strict"; | |
| /** | |
| * Initialize the SVG Fixer after the DOM is ready | |
| */ | |
| document.addEventListener("DOMContentLoaded", function() { | |
| /** | |
| * Current URL, without the hash | |
| */ | |
| var baseUrl = window.location.href | |
| .replace(window.location.hash, ""); | |
| /** | |
| * Find all `use` elements with a namespaced `href` attribute, e.g. | |
| * <use xlink:href="#some-id"></use> | |
| * | |
| * See: http://stackoverflow.com/a/23047888/796152 | |
| */ | |
| [].slice.call(document.querySelectorAll("use[*|href]")) | |
| /** | |
| * Filter out all elements whose namespaced `href` attribute doesn't | |
| * start with `#` (i.e. all non-relative IRI's) | |
| * | |
| * Note: we're assuming the `xlink` prefix for the XLink namespace! | |
| */ | |
| .filter(function(element) { | |
| return (element.getAttribute("xlink:href").indexOf("#") === 0); | |
| }) | |
| /** | |
| * Prepend `window.location` to the namespaced `href` attribute value, | |
| * in order to make it an absolute IRI | |
| * | |
| * Note: we're assuming the `xlink` prefix for the XLink namespace! | |
| */ | |
| .forEach(function(element) { | |
| element.setAttribute("xlink:href", baseUrl + element.getAttribute("xlink:href")); | |
| }); | |
| }, false); | |
| }(document, window)); |
Thanks for this polyfill !
Same here. Many thanks !!!!
Thanks a lot ❤️ ❤️ ❤️
Huge thanks from me too!
Since I am male no red hearts but both thumbs up, a long and happy life, and again many thanks for saving my day.
@leonderijke, thank you big time! if only I could get the time back I wasted finding out what causes that in a huge app))
As far as I can tell this is an issue in Chrome as well.
Thanx for that. You saved my life!
This is great! But still has problem in Chrome.
You good sir, have just saved me from seeing a 70+ hour plugin fail miserably because its icons wouldn't show.
Long life to you.
Thanks a ton! Can we get a license for this?
Sometimes I have some # links that I forgot to preventDefault and when I have locations like localhost:3000/# the script does not work properly.
You can add .replace('#', ''); to the baseUrl after replacing hash
Great find, it took me a while to figure out the my BASE tag was the culprit.
Tip for people using Angular or React: make a SVG component that does the path replacement on render.
For my angular app, the Domload event would happen before any of the ng-repeated rows would be rendered so the paths would not be replaced. Turning the svg into a component solved that for me since on creation I could replace the path.
cheers
Thanks!
This saved my team the work of re-exporting all of our SVGs, thanks!
This workaround will soon not be needed anymore. Firefox and Edge are changing behaviours so by October 2017, we can remove it from our projects.
Saved my day, thanks!!
Thanks!!!!!
Thank you very much, Sir! 👍
The same behavior occurs with "fill" attribute as well. Added one more statement to handle that in the workaround. Not sure if there will be more attributes that may be affected by tag.
/* * Find alluseelements with a namespacedfill` attribute, e.g.
*
*
* See: http://stackoverflow.com/a/23047888/796152
*/
[].slice.call(document.querySelectorAll("use[*|fill]"))
/**
* Filter out all elements whose namespaced `fill` attributes doesn't
* which doesnt have cross referenced values
*
* Note: we're assuming the `url(` prefix for the cross referenced fills !
*/
.filter(function(element) {
return (element.getAttribute("fill").indexOf("url(") === 0);
})
/**
* Insert `window.location` to the `fill` attribute value,
* in order to make it an absolute IRI
*
*/
.forEach(function(element) {
var attrVal = element.getAttribute("fill");
var idx = attrVal.indexOf("url(");
element.setAttribute("fill",attrVal.slice(0,idx+4)+baseUrl+ attrVal.slice(idx+4));
}); `
Thank you so much!
This is fantastic. Thank you 👍
Hello Everyone, Sorry if I my question is too naive. It seems I am having same issue in Microsoft Edge. How can I use the mentioned code snippet in my application ?. Do I have to include it in polyfills.ts file ?. Can someone help me out please ?. I tried adding it in polyfills.ts and adding this snippet using script tag in index.html file, but still not seeing icons in Edge and FF
Just giving it another shot, is anyone still active here to help me out ?
As a note, the mask attribute is affected too. And this kind of fix is still needed for Safari (iOS / macOS), btw.
Thanks... This helped me to get my svgs working on Firefox