Fix gh-r get_latest due to URL scheme change of GitHub #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstapler
added a commit
to tstapler/zplug
that referenced
this pull request
Oct 31, 2023
Taken from this PR zplug#589
|
Hey @andreicozma1, Thanks for putting up this PR it solved the problem I was facing when using Unfortunately, it looks like your changes introduce this bug with ❯ zplug update
[zplug] Start to update 22 plugins in parallel
⠸ Updating... zsh-users/zaw
⠼ Updating... zsh-users/zawps
⠴ Updating... zsh-users/zawpsompletions
⠴ Updating... djui/alias-tipsompletions
⠦ Updating... zsh-users/zaw-completions
⠧ Updating... zsh-users/zawpshooks
⠴ Updating... zsh-users/zawpsompletions
⠴ Updating... djui/alias-tipsompletionsei-git-plugin
⠴ Updating... zsh-users/zsh-completionsei-git-plugin
⠴ Updating... willghatch/zsh-hooks-sensei-git-plugin
✘ Not on any branch zsh-users/zawautoenv-highlighting
⠦ Updating... djui/alias-tipsy-zsh-sensei-git-plugin
⠦ Updating... zsh-users/zsh-completionsei-git-plugin
⠦ Updating... willghatch/zsh-hooks-sensei-git-plugin
⠦ Updating... Tarrasch/zsh-autoenv-highlightingearch
⠦ Updating... plugins/asdfncd-bug
✔ Updated! jqlang/jqetionhistory-substring-search
⠦ Updating... aswitalski/oh-my-zsh-sensei-git-plugin
⠦ Updating... zsh-users/zsh-syntax-highlightingearch
✘ Not on any branch zsh-users/zawcd-bugeases
⠧ Updating... djui/alias-tips-bug
✘ Not on any branch zsh-users/zsh-completions
✘ Not on any branch zsh-users/zawh-hooksy-substring-search
⠇ Updating... djui/alias-tipstoenveleases
✘ Not on any branch zsh-users/zaw-completions such file or directory
✘ Not on any branch djui/alias-tipshooksy: No such file or directory
✘ Not on any branch zsh-users/zsh-completionsei-git-plugin
⠏ Updating... willghatch/zsh-hooks-highlightingle or directory
✘ Not on any branch Tarrasch/zsh-autoenvy: No such file or directory
⠏ Updating... plugins/asdfh-my-zsh-sensei-git-plugin directory
✘ Not on any branch zsh-users/zaw-syntax-highlightingle or directory
✘ Not on any branch djui/alias-tipsy-zsh-sensei-git-plugin directory
✘ Not on any branch zsh-users/zsh-completionslightingle or directory
⠋ Updating... willghatch/zsh-hooksy: No such file or directory
✘ Not on any branch zsh-users/zawautoenvy-substring-search directory
✘ Not on any branch djui/alias-tips
✘ Not on any branch zsh-users/zsh-completionsstring-search directory
✘ Not on any branch willghatch/zsh-hooks-sensei-git-plugin directory
✘ Not on any branch Tarrasch/zsh-autoenv-highlighting
⠙ Updating... plugins/asdfdirectory: No such file or directory
✔ Updated! jqlang/jqnhancd
✘ Not on any branch aswitalski/oh-my-zsh-sensei-git-plugin directory
✘ Not on any branch zsh-users/zaw-syntax-highlightingle or directory
✘ Not on any branch zsh-users/zawpsistory-substring-search directory
✘ Not on any branch djui/alias-tipsompletions such file or directory
✘ Not on any branch zsh-users/zsh-completions such file or directory
✘ Not on any branch willghatch/zsh-hooksy-substring-search directory
✘ Not on any branch Tarrasch/zsh-autoenv
✘ Not on any branch plugins/asdfctlectory: No such file or directory
✔ Updated! jqlang/jqi/oh-my-zsh-sensei-git-plugin
✘ Not on any branch aswitalski/oh-my-zsh-sensei-git-plugin
✘ Not on any branch zsh-users/zsh-syntax-highlightingle or directory
✘ Not on any branch b4b4r07/enhancdectory: No such file or directory
✘ Not on any branch lib/completionrectory: No such file or directory
✔ Updated! junegunn/fzfh-history-substring-search directory
✘ Not on any branch zsh-users/zsh-history-substring-search directory
✘ Not on any branch plugins/httpielectory: No such file or directory
✘ Not on any branch plugins/kubectl-bugry: No such file or directory
✔ Updated! MichaelMure/git-bug
✘ Repo not found plugins/aws
✘ Repo not found zplug/zplug directory: No such file or directory
✘ Repo not found tarruda/zsh-autosuggestions
✘ Repo not found romkatv/powerlevel10k
✘ Repo not found plugins/git
✘ Repo not found clvv/fasd
[zplug] Elapsed time: 2.8663 sec.
==> Updating finished successfully! |
|
hi @tstapler I cannot reproduce this issue. Tested on both my macOS and Ubuntu machines. Do you happen to have any additional details? 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/$repo/releases/latest now redirects to a tag page, so must extract the latest tag from the URL.
wwcd/zplug had a fix using the CURL command, but would remove the WGET alternative completely.
This PR fixes both, keeping both the CURL and WGET functionality
