Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github CI workflow for tests and related bugfixes #551

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

yumitsu
Copy link

@yumitsu yumitsu commented Jul 7, 2020

Fixes #519, fixes #393. Kinda related to #116. Also one of required goals for v2.5.0 (#538).

draftcode and others added 10 commits July 7, 2020 04:49
When git is built from source, the `git version` output contains
non-numeric version components.

```
$ git version
git version 2.24.0.rc2.46.g1d34d425d4
```

zplug cannot detect the git version with this output, and it fails to
start. Change the version pattern to extract a part that starts with a
digit. For the example above, zplug will detect the git version as
"2.24.0.rc2.46.g1d34d425d4". This is good enough for the version check
while there would be no false positives.
@yumitsu yumitsu requested a review from a team as a code owner July 7, 2020 01:58
@yumitsu yumitsu mentioned this pull request Jul 7, 2020
@yumitsu yumitsu changed the title Github CI workflow for tests and bugfixes Github CI workflow for tests and related bugfixes Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zplug tput error when run non-interatively Issue when installing zplug with Ansible
2 participants