-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github CI workflow for tests and related bugfixes #551
Open
yumitsu
wants to merge
12
commits into
zplug:master
Choose a base branch
from
yumitsu:workflow-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When git is built from source, the `git version` output contains non-numeric version components. ``` $ git version git version 2.24.0.rc2.46.g1d34d425d4 ``` zplug cannot detect the git version with this output, and it fails to start. Change the version pattern to extract a part that starts with a digit. For the example above, zplug will detect the git version as "2.24.0.rc2.46.g1d34d425d4". This is good enough for the version check while there would be no false positives.
yumitsu
changed the title
Github CI workflow for tests and bugfixes
Github CI workflow for tests and related bugfixes
Jul 7, 2020
Reverted change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #519, fixes #393. Kinda related to #116. Also one of required goals for v2.5.0 (#538).