Don't produce invalid HTML warning for CDATA

If a field contains a CDATA section, don't produce a warning saying that it contains invalid HTML tags. See kerrickstaley#108
zhaisilong · May 22, 2022 · 2f22b94 · 2f22b94
1 parent 1b43c75
commit 2f22b94
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/genanki/note.py b/genanki/note.py
@@ -48,7 +48,7 @@ def insert(self, i, tag):
 
 
 class Note:
-  _INVALID_HTML_TAG_RE = re.compile(r'<(?!/?[a-zA-Z0-9]+(?: .*|/?)>|!--)(?:.|\n)*?>')
+  _INVALID_HTML_TAG_RE = re.compile(r'<(?!/?[a-zA-Z0-9]+(?: .*|/?)>|!--|!\[CDATA\[)(?:.|\n)*?>')
 
   def __init__(self, model=None, fields=None, sort_field=None, tags=None, guid=None, due=0):
     self.model = model

diff --git a/tests/test_note.py b/tests/test_note.py
@@ -211,6 +211,10 @@ def test_ok_html_comment(self):
     # see https://github.com/kerrickstaley/genanki/issues/108
     assert genanki.Note._find_invalid_html_tags_in_field('<!-- here is a comment -->') == []
 
+  def test_ok_cdata(self):
+    # see https://github.com/kerrickstaley/genanki/issues/108
+    assert genanki.Note._find_invalid_html_tags_in_field('<![CDATA[ here is some cdata ]]>') == []
+
 
 def test_warns_on_invalid_html_tags():
   my_model = genanki.Model(