Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(OnClickOutside): support component with fragments #4313

Merged
merged 2 commits into from
Nov 21, 2024
Merged

feat(OnClickOutside): support component with fragments #4313

merged 2 commits into from
Nov 21, 2024

Conversation

ilyaliao
Copy link
Contributor

@ilyaliao ilyaliao commented Oct 29, 2024 •
edited
Loading

fix #4248

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

This PR adds support for multi-root components.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 29, 2024
@antfu antfu changed the title perf(OnClickOutside): support component with fragments feat(OnClickOutside): support component with fragments Oct 30, 2024
antfu
antfu reviewed Oct 30, 2024
View reviewed changes
packages/core/onClickOutside/index.ts Outdated
return false

// @ts-expect-error should be VNode
return children.some((child: VNode) => child.el === eventTarget)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably support event.composedPath() as in L102.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!

@antfu antfu enabled auto-merge November 21, 2024 08:05
@antfu antfu added this pull request to the merge queue Nov 21, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 21, 2024
Merged via the queue into vueuse:main with commit fe322bd Nov 21, 2024
8 checks passed
@ilyaliao ilyaliao deleted the fix/issue-4248 branch November 21, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onClickOutside gets triggered if used multi-root components
2 participants
@ilyaliao @antfu