Move UFS spec headers into MdePkg/IndustryStandard files and update to UFS 4.0 #6438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
lgao4,
LiuZhiguang001,
mdkinney and
niruiyu
zurcher
force-pushed
the
ufs_spec
branch
4 times, most recently
from
3e20d36 to
fedc825
Compare
zurcher
changed the title
|
This PR contains 3 separate commits that should be kept separate, and not merged into a single commit. |
lgao4
approved these changes
Dec 6, 2024
These files are direct ports from the (identical) files: MdeModulePkg\Bus\Ufs\UfsBlockIoPei\UfsHci.h MdeModulePkg\Bus\Ufs\UfsPassThruDxe\UfsPassThruHci.h Signed-off-by: Christopher Zurcher <[email protected]>
Remove duplicate private header files and reference UFS spec definitions from the IndustryStandard folder. Signed-off-by: Christopher Zurcher <[email protected]>
Signed-off-by: Christopher Zurcher <[email protected]>
|
@lgao4 Can you help move this PR forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The spec-based header definitions for UFS drivers are currently in two identical private header files. This change set moves the definitions into the IndustryStandard folder with two separate files tracking relevant UFS spec documents. This will allow for future spec updates to be made in a single location, and allows for other drivers to access these definitions.
Additionally, this set updates Ufs.h to the UFS 4.0 spec.
How This Was Tested
Added UfsBlockIoPei and UfsPassThruDxe to OvmfPkg, and built successfully.
Integration Instructions
Drivers can now include
<IndustryStandard/Ufs.h>to interact with UFS interfaces such as<Protocol/UfsDeviceConfig.h>.