perf: scan: preallocate and reuse a single PathBuf
#6387
+36
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poliorcetics
force-pushed
the
ab/push-ssmnukyyston
branch
from
99e4249
to
a80d340
Compare
jankatins
reviewed
Nov 11, 2024
jankatins
reviewed
Nov 11, 2024
poliorcetics
force-pushed
the
ab/push-ssmnukyyston
branch
from
a80d340
to
33ea390
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To improve performances, reuse a single allocation in
ScanAncestors::scan()Motivation and Context
Testing on a fairly deep path (7 folders), this makes a
.markerdir search go from ~1ms to ~600µs somewhat consistently. Sincestarshipis run extremely often, I think any kind of perf improvement (for notably the case where there is no.marker) is nice.Here it makes the code longer, and probably a little more complex, but I don't think it's hard to understand by any means, especially with the comments
Screenshots (if appropriate):
How Has This Been Tested?
Checklist:
The tests must not be updated, else it means I broke something