feat(spin): add new module for Spin #6238
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thorsten Hans <[email protected]>
Signed-off-by: Thorsten Hans <[email protected]>
ThorstenHans
force-pushed
the
feature/spin-module
branch
from
9736d10 to
74693eb
Compare
davidkna
reviewed
Sep 9, 2024
src/modules/spin.rs
Outdated
Comment on lines
74
to
79
| let capture = semver_regex.find(input)?.as_str(); | ||
| if input.contains(SPIN_CANARY_IDENTIFIER) { | ||
| Some(format!("{} ({})", capture, SPIN_CANARY)) | ||
| } else { | ||
| Some(capture.to_string()) | ||
| } |
There was a problem hiding this comment.
Why do you replace pre in the version name with canary?
There was a problem hiding this comment.
Initially I thought it would be more self-explaining. However, you're right, 2.8.0 (pre) makes more sense than 2.8.0 (canary)
There was a problem hiding this comment.
I am not sure if rewriting the version here at all is a good idea.
There was a problem hiding this comment.
Okay, I changed the implementation to use versions provided by spin --version as they are
Signed-off-by: Thorsten Hans <[email protected]>
Signed-off-by: Thorsten Hans <[email protected]>
|
@davidkna any chance to get a new review? |
…by spin Signed-off-by: Thorsten Hans <[email protected]>
davidkna
reviewed
Oct 16, 2024
Signed-off-by: Thorsten Hans <[email protected]>
davidkna
requested changes
Oct 19, 2024
Co-authored-by: David Knaack <[email protected]>
Co-authored-by: David Knaack <[email protected]>
Co-authored-by: David Knaack <[email protected]>
Co-authored-by: David Knaack <[email protected]>
Signed-off-by: Thorsten Hans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new module for Spin, allowing Spin users to display the currently installed version of the Spin CLI in their prompt.
Motivation and Context
As a developer using Spin to build WebAssembly applications, I want to display the current version of Spin as part of my prompt. This is especially useful for Spin users that leverage Spin's version manager to switch between multiple versions of Spin on their machine.
Screenshots (if appropriate):
How Has This Been Tested?
I installed Spin CLI on my machine using homebrew (
brew install fermyon/tap/spin), and updated mystarship.tomlby adding:To display the currently installed version of Spin also outside of Spin App directories, I set the
permanentoption totrue.Checklist: