fix: replaced imageDescriptors [IDE-793] #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acke
changed the title
Comment on lines
+26
to
+29
| public static final ImageDescriptor PROJECT = Activator | ||
| .getImageDescriptor("platform:/plugin/org.eclipse.ui.ide/icons/full/obj16/prj_obj.png"); | ||
| public static final ImageDescriptor FILE = Activator | ||
| .getImageDescriptor("platform:/plugin/org.eclipse.ui.genericeditor/icons/full/obj16/generic_editor.png"); |
There was a problem hiding this comment.
this fixes the issue, but what if we have a file icon that is not the generic editor one?
There was a problem hiding this comment.
E.g. a Java file, or a Python file when PyDev is installed.
There was a problem hiding this comment.
How about we keep the original logic, but replace the return null, with return SnykIcons.PROJECT for project nodes and SnykIcons.FILE for file nodes?
acke
force-pushed
the
fix/IDE-793_wrong_icons
branch
from
cf9abb7
to
bc27577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The project and file icons now shows as they should.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!