-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/IDE-739 branch selection node #229
Open
acke
wants to merge
21
commits into
main
Choose a base branch
from
feat/IDE-739_branch_selection_node
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acke
force-pushed
the
feat/IDE-739_branch_selection_node
branch
from
November 28, 2024 16:13
ecffd16
to
45d0f24
Compare
bastiandoetsch
changed the title
Feat/ide 739 branch selection node
feat: add UI for branch selection and delta filters [IDE-739]
Dec 2, 2024
plugin/src/main/java/io/snyk/eclipse/plugin/properties/preferences/EclipsePreferenceState.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/eclipse/plugin/properties/preferences/EclipsePreferenceState.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/eclipse/plugin/views/MenuHandler.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/RootNode.java
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/SnykToolView.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/SnykToolView.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/SnykToolView.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/SnykToolView.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/languageserver/LsConfigurationUpdater.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java
Show resolved
Hide resolved
Comment on lines
+56
to
+57
public void setAdditionalParameters(List<String> additionalParameters) { | ||
this.additionalParameters = additionalParameters != null ? additionalParameters : List.of(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be synchronized to project settings. How is it integrated with the PreferencePage?
acke
changed the title
feat: add UI for branch selection and delta filters [IDE-739]
Feat/IDE-739 branch selection node
Dec 2, 2024
acke
force-pushed
the
feat/IDE-739_branch_selection_node
branch
4 times, most recently
from
December 4, 2024 12:16
5f5e767
to
6e471be
Compare
…tup if state is true. Put a current branch in the Dialog combobox. Validate that the text from the combobox is equal to one of the existing branches. Update root node with choosen branch. Start a scan when clicking ok in the dialog. Set nodes to delta nodes when Eclipse starts.
…dater().configurationChanged() is called
acke
force-pushed
the
feat/IDE-739_branch_selection_node
branch
from
December 4, 2024 13:52
7e2d7fc
to
56add6d
Compare
acke
force-pushed
the
feat/IDE-739_branch_selection_node
branch
from
December 4, 2024 14:18
5268584
to
d99852c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No open projects in Eclipse
Net new issues on View menu
Branch selection dialog
Scanning multiple projects with Delta scan
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!