Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add branch selection node [IDE-739] #229

Merged
merged 24 commits into from
Dec 5, 2024

Conversation

acke
Copy link
Contributor

@acke acke commented Nov 28, 2024

Description

  • Preference state for Delta findings.
  • Branch selection node to tree.
  • Branch selection dialog.
  • Handle FolderConfig notification.
  • Support for doing a scan on a specific project.
  • Enable/disable Net new issues option to the Viewmenu.
  • Added handling of the case where Eclipse is opened without a project.

No open projects in Eclipse
image

Net new issues on View menu
image

Branch selection dialog
image

Scanning multiple projects with Delta scan
image

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@acke acke force-pushed the feat/IDE-739_branch_selection_node branch from ecffd16 to 45d0f24 Compare November 28, 2024 16:13
@acke acke marked this pull request as ready for review November 28, 2024 16:28
@acke acke requested a review from a team as a code owner November 28, 2024 16:28
@bastiandoetsch bastiandoetsch changed the title Feat/ide 739 branch selection node feat: add UI for branch selection and delta filters [IDE-739] Dec 2, 2024
@acke acke changed the title feat: add UI for branch selection and delta filters [IDE-739] Feat/IDE-739 branch selection node Dec 2, 2024
@acke acke force-pushed the feat/IDE-739_branch_selection_node branch 4 times, most recently from 5f5e767 to 6e471be Compare December 4, 2024 12:16
…tup if state is true.

Put a current branch in the Dialog combobox.
Validate that the text from the combobox is equal to one of the existing
branches.
Update root node with choosen branch.
Start a scan when clicking ok in the dialog.
Set nodes to delta nodes when Eclipse starts.
@acke acke force-pushed the feat/IDE-739_branch_selection_node branch from 5268584 to d99852c Compare December 4, 2024 14:18
@bastiandoetsch bastiandoetsch changed the title Feat/IDE-739 branch selection node feat: add branch selection node [IDE-739] Dec 5, 2024
bastiandoetsch and others added 2 commits December 5, 2024 10:46
…#237)

* feat: add ToS and privacy, remove old legacy view

* chore: remove legacy view from plugin.xml

* chore: update theme id for background colors
@acke acke force-pushed the feat/IDE-739_branch_selection_node branch 2 times, most recently from 94bdefe to f115596 Compare December 5, 2024 10:41
import io.snyk.languageserver.protocolextension.SnykExtendedLanguageClient;

public class BaseBranchDialog {
private FolderConfigs preferenceState = FolderConfigs.getInstance();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename as discussed

commit ba6787a
Author: Bastian Doetsch <[email protected]>
Date:   Thu Dec 5 09:50:25 2024 +0100

    feat: add ToS and privacy, remove old legacy view [IDE-810] [IDE-713] (#237)

    * feat: add ToS and privacy, remove old legacy view

    * chore: remove legacy view from plugin.xml

    * chore: update theme id for background colors
Merge branch 'main' into feat/IDE-739_branch_selection_node
@acke acke force-pushed the feat/IDE-739_branch_selection_node branch from f115596 to 5279418 Compare December 5, 2024 11:02
@acke acke merged commit d05e763 into main Dec 5, 2024
7 checks passed
@acke acke deleted the feat/IDE-739_branch_selection_node branch December 5, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants