Ability to set template cache key #486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SpeedyStuart, please fix the conflict |
hishamco
requested changes
Sep 27, 2023
| @@ -15,7 +15,6 @@ namespace Fluid.ViewEngine | |||
| public class FluidViewRenderer : IFluidViewRenderer | |||
| { | |||
| private static readonly char[] PathSeparators = { '/', '\\' }; | |||
|
|
|||
| /// <summary> | ||
| /// Represents the method that will generate a cache key for a supplied template path. Allows templates to be cached based on any external factor. | ||
| /// </summary> | ||
| public delegate string TemplateCacheKeyProviderDelegate(string path); |
There was a problem hiding this comment.
I'm not sure if it's a good idea to have a delegate, I'm thinking of providing another API for caching or using IMemoryCache where the cache key could be provided by the user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows implementers to provide a delegate for generating the key that's used for template caching/retrieval. Therefore it allows templates to be cached based on something other than (just) their path + name.
Used with a custom file provider it allows different templates to be served based on arbitrary request properties - e.g. user-agent, cookie etc.
Possible solution for #470