-
Notifications
You must be signed in to change notification settings - Fork 327
Guard operations that mutates an EBS volume with a Mutex #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1345 +/- ##
=======================================
Coverage 34.20% 34.20%
=======================================
Files 36 36
Lines 2362 2362
=======================================
Hits 808 808
Misses 1451 1451
Partials 103 103 Continue to review full report at Codecov.
|
Looks good to me, except the attempt to fix the Merged this into a fork https://github.com/nbryant42/rexray/tree/collected-prs which I am using to build https://gallery.ecr.aws/j1l5j1d1/rexray-ebs |
On my local branch mentioned above, I now see intermittent mount failures when ECS tries to place a task, with the |
Reverted this PR from the binaries I'm publishing, because it seems to be causing regressions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing approval. seems to cause regressions.
Closes #1284