Codecov Report

Merging #1124 into master will increase coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
+ Coverage   34.25%   34.54%   +0.29%     
==========================================
  Files          36       36              
  Lines        2362     2362              
==========================================
+ Hits          809      816       +7     
+ Misses       1450     1442       -8     
- Partials      103      104       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ed0b78...8a153d7. Read the comment docs.

Hi @jmaitrehenry,

Please rebase this onto master. After that, I will need to ponder this a bit. I agree with some of your changes, while others I find a matter of preference.

@akutz Done, let's discuss on the changes, maybe I can split this PR in two, the first one on thing we agree, and the other one as a proposal where we can discuss.

Hi @jmaitrehenry,

Thank you! Instead of modifying a minified CSS file I'd prefer you override those rules with !important in a separate file. Or would that not work?

Hi @jmaitrehenry,

FYI, I've no issues with this PR other than the one I raised above (the modification to a minified CSS file). Once we resolve that discussion I will merge the change. Thank you again for this!

@akutz great, I try to find the change on the minified css, I don't know why is it modified, I do not do that normally.

Hi @jmaitrehenry,

Actually, I take all that back :) Will you please first test the changes by enabling your browser's dev mode and verifying the updates don't break mobile mode? For example, here's Safari's Responsive Design Mode:

Chrome also has this ability.

Hi @jmaitrehenry,

I try to find the change on the minified css, I don't know why is it modified, I do not do that normally.

You mean you didn't intend to modify that file? Except you say here that you did modify it...

I see some places where we use <center>title</center> syntax for th cell. I remove the rules inside bootstrap-custom.min.css for force align the text to the right.

Oh didn't see it, I made it months ago. Ok, let me check on mobile and remove the modification inside .min file.

Hi @jmaitrehenry,

Thank you. Please see if the change can be made using !important in one of the custom CSS files. If not...I mean...hmm. I just hate modifying stock files like that. Especially when they're minified. It makes it difficult to ensure changes are persisted if those stock files are updated.

For mobile:

I will change the table rendering for phone, it's too big and the table is less readable than before.