Fix ignoring entire mapping and sequence.#16756
Open
fyc09 wants to merge 11 commits intoprettier:mainfrom
Open
Fix ignoring entire mapping and sequence.#16756fyc09 wants to merge 11 commits intoprettier:mainfrom
fyc09 wants to merge 11 commits intoprettier:mainfrom
Conversation
fyc09
force-pushed
the
fix-yaml-ignore
branch
from
651f371 to
5a93610
Compare
commit: |
Contributor
Author
|
Can anyone review it? |
fisker
reviewed
Dec 20, 2024
Contributor
Author
|
Can anyone review it? |
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
fisker
reviewed
Feb 25, 2025
fisker
reviewed
Aug 30, 2025
| (parent) => | ||
| hasLeadingComments(parent.node) && | ||
| isPrettierIgnore(parent.node.leadingComments.at(-1)), | ||
| )) |
Member
There was a problem hiding this comment.
We are ignoring mappingItem separately, so the parent is not correctly ignored.
For example, spacing is not preserved.
Prettier pr-16756
Playground link
--parser yamlInput:
# prettier-ignore
abc: 123
def: 456Output:
# prettier-ignore
abc: 123
def: 456
Contributor
Author
There was a problem hiding this comment.
But in this way, I can't ignore the first item in an object separately.
Member
There was a problem hiding this comment.
I'll try to understand the original issue better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix bug in #13008. Added a check to determine whether the YAML ignore comment is at the beginning of the file.
Checklist
(If changing the API or CLI) I’ve documented the changes I’ve made (in thedocs/directory).(If the change is user-facing) I’ve added my changes tochangelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨