Fix markdown inserts unexpected newline in lists by byplayer · Pull Request #16637 · prettier/prettier

byplayer · 2024-09-07T08:05:36Z

Description

I fix markdown inserts unexpected newline in lists.

This issue is reported the below link.
#8004

Fixes #8004

Checklist

I’ve added tests to confirm my change works.
(If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)(not change).
(If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md(not change).
I’ve read the contributing guidelines.

✨Try the playground for this PR✨

I fix markdown inserts unexpected newline in lists. This issue is reported the below link. prettier#8004

There is lint error for changelog_unreleased/markdown/16637.md, threfore I fix it with 'prettier --write' command.

I remove 'markdown:' from change log title.

barcell1 · 2024-12-20T18:36:25Z

1 on this

jacksteamdev

LGTM, one minor observation.

jacksteamdev · 2025-01-16T20:40:00Z

src/language-markdown/printer-markdown.js

+    parent.type === "listItem" &&
+    (node.type === "list" ||
+      (node.type !== "list" && !isLooseListItem(parent, options)));


parent.type === "listItem" && (node.type === "list" || (node.type !== "list" && // is always true !isLooseListItem(parent, options)));

The condition can be simplified since the node.type !== "list" check is redundant - if the first part of the OR (node.type === "list") is false, then node.type !== "list" will always be true. Due to short-circuit evaluation, we can remove this redundant check while maintaining the same logic.

Suggested change

parent.type === "listItem" &&

(node.type === "list" ||

(node.type !== "list" && !isLooseListItem(parent, options)));

parent.type === "listItem" &&

(node.type === "list" || !isLooseListItem(parent, options));

I hope this PR can be reviewed and merged soon! 🤞

I fix it.
Thank you.

The suggested condition of the bellow URL is better than current one. I fix it. prettier#16637 (comment)

jacksteamdev · 2025-05-02T17:26:36Z

@thorn0 Thanks for helping maintain this project! I noticed that you triaged #8004, is there any possibility this high-quality PR could get reviewed by a Prettier maintainer?

netlify · 2025-05-21T03:54:38Z

✅ Deploy Preview for prettier ready!

Name	Link
🔨 Latest commit	`b7fd2dc`
🔍 Latest deploy log	https://app.netlify.com/projects/prettier/deploys/683b3c13c942b30008d5a1f6
😎 Deploy Preview	https://deploy-preview-16637--prettier.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

pkg-pr-new · 2025-05-21T03:55:10Z

Open in StackBlitz

yarn add https://pkg.pr.new/prettier/prettier/@prettier/[email protected]

yarn add https://pkg.pr.new/prettier/prettier/@prettier/[email protected]

yarn add https://pkg.pr.new/prettier/[email protected]

commit: b7fd2dc

mikaello · 2025-06-23T08:59:40Z

It may be a regression when combined with fenced code blocks and nested lists:

Before this PR:

1. Some text, and code block below

   ```yaml
   ---
   foo: bar
   ```

   1. Another
   2. List

After this PR, notice removed newline after code block:

1. Some text, and code block below

   ```yaml
   ---
   foo: bar
   ```
   1. Another
   2. List

This is at least in conflict with MD031 for those using markdownlint.

fisker · 2025-06-23T09:16:45Z

Can you open a new issue?

Because a Prettier update (v3.6.0) came out 7 hours ago, containing changes that alter the way Markdown is formatted: - https://prettier.io/blog/2025/06/23/3.6.0#markdown Notably: - prettier/prettier#16637 Locally, I'm running prettier with `npx`, so I get those changes immediately. In CI, runs are failing: ``` 2025-06-23T09:16:20.1272956Z ##[group]Run actionsx/prettier@3d9f7c3 2025-06-23T09:16:20.1273344Z with: 2025-06-23T09:16:20.1273543Z args: --list-different "**/*.md" 2025-06-23T09:16:20.1274004Z ##[endgroup] 2025-06-23T09:16:20.5373798Z lua/wincent/commandt/README.md ``` - https://github.com/wincent/command-t/actions/runs/15820236003 Given that `actionsx/prettier` was last updated two years ago: - https://github.com/actionsx/prettier/releases/tag/v3 And there has been a request to bump Prettier to v3.0.3 that has gone ignored since October 2023: - actionsx/prettier#117 I am not optimistic that this will be resolved quickly, although I recognize that I might be pleasantly surprised. Whatever. Enough idle speculation. I'm using dprint quite happily in other projects, so let's use it here too.

mikaello · 2025-06-23T09:53:36Z

Can you open a new issue?

Sure: #17652

Change introduced in prettier/prettier#16637

* build(deps-dev): Bump the dev-dependencies group with 11 updates --- updated-dependencies: - dependency-name: "@eslint/js" dependency-version: 9.30.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: "@vitest/eslint-plugin" dependency-version: 1.3.4 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: concurrently dependency-version: 9.2.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: eslint dependency-version: 9.30.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: eslint-import-resolver-typescript dependency-version: 4.4.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: eslint-plugin-import dependency-version: 2.32.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: globals dependency-version: 16.3.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: prettier dependency-version: 3.6.2 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: tsx dependency-version: 4.20.3 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: typescript-eslint dependency-version: 8.35.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: vitest dependency-version: 3.2.4 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> * chore: Fix new Prettier issue Change introduced in prettier/prettier#16637 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Hoff-Vanoni <[email protected]>

Fix formatting in the docs/content/development/getting-started.md (caused by the Prettier upgrade from 3.5.x to 3.6.x, Fix markdown inserts unexpected newline in lists prettier/prettier#16637).

…noni#699) * build(deps-dev): Bump the dev-dependencies group with 11 updates --- updated-dependencies: - dependency-name: "@eslint/js" dependency-version: 9.30.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: "@vitest/eslint-plugin" dependency-version: 1.3.4 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: concurrently dependency-version: 9.2.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: eslint dependency-version: 9.30.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: eslint-import-resolver-typescript dependency-version: 4.4.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: eslint-plugin-import dependency-version: 2.32.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: globals dependency-version: 16.3.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: prettier dependency-version: 3.6.2 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: tsx dependency-version: 4.20.3 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: typescript-eslint dependency-version: 8.35.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: vitest dependency-version: 3.2.4 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> * chore: Fix new Prettier issue Change introduced in prettier/prettier#16637 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Hoff-Vanoni <[email protected]>

byplayer added 2 commits September 7, 2024 17:01

👍 fix Markdown inserts unexpected newline in lists

e4ec794

I fix markdown inserts unexpected newline in lists. This issue is reported the below link. prettier#8004

📝 add change log for PR 16637

e633f01

byplayer mentioned this pull request Sep 7, 2024

Markdown inserts unexpected newline in lists #8004

Closed

byplayer added 4 commits November 2, 2024 16:45

🔀 Merge branch 'main' into bugfix/markdown_unexpected_newline

f8ff0e7

👕 fix lint error for changelog_unreleased/markdown/16637.md

ffdcc41

There is lint error for changelog_unreleased/markdown/16637.md, threfore I fix it with 'prettier --write' command.

👍 remove template comment for changelog file

5403638

👍 Remove markdown: from change log title

58504e9

I remove 'markdown:' from change log title.

jacksteamdev approved these changes Jan 16, 2025

View reviewed changes

👍 fix suggested if condition

6acb8bb

The suggested condition of the bellow URL is better than current one. I fix it. prettier#16637 (comment)

Update 16637.md

6eb23db

fisker changed the title ~~markdown: fix markdown inserts unexpected newline in lists~~ Fix markdown inserts unexpected newline in lists May 21, 2025

fisker approved these changes May 21, 2025

View reviewed changes

fisker added this to the 3.6 milestone May 21, 2025

sosukesuzuki approved these changes May 31, 2025

View reviewed changes

Merge branch 'main' into bugfix/markdown_unexpected_newline

b7fd2dc

sosukesuzuki merged commit 4bb0568 into prettier:main May 31, 2025
32 of 33 checks passed

fisker mentioned this pull request Jun 23, 2025

fix(markdown): prevent extra blank line before nested list #17606

Closed

mashehu mentioned this pull request Jun 23, 2025

Blank line between list and sublist item #17582

Closed

mikaello mentioned this pull request Jun 23, 2025

Markdown: newline removed around code block in v3.6.0 #17652

Closed

daragh-king-genesys mentioned this pull request Jun 23, 2025

chore(other): update lint dependencies MyPureCloud/genesys-spark#1195

Merged

galtm mentioned this pull request Jun 26, 2025

ci(deps-dev): bump prettier from 3.5.3 to 3.6.1 xspec/xspec#2138

Merged

fgimian mentioned this pull request Jun 29, 2025

Potentially cramped appearance of sub-lists in Markdown since 3.6.0 #17690

Open

dvanoni added a commit to dvanoni/notero that referenced this pull request Jul 5, 2025

chore: Fix new Prettier issue

35b05ad

Change introduced in prettier/prettier#16637

andersk mentioned this pull request Jul 22, 2025

[3.6 regression] Semantically changes Markdown loose list to tight list #17746

Open

TYKevin mentioned this pull request Jul 27, 2025

Fix(Markdown): inserts newline in lists containing codeblock but skips last element #17760

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix markdown inserts unexpected newline in lists#16637

Fix markdown inserts unexpected newline in lists#16637
sosukesuzuki merged 9 commits intoprettier:mainfrom
byplayer:bugfix/markdown_unexpected_newline

byplayer commented Sep 7, 2024 •

edited by fisker

Loading

Uh oh!

barcell1 commented Dec 20, 2024

Uh oh!

jacksteamdev left a comment

Uh oh!

jacksteamdev Jan 16, 2025

Uh oh!

byplayer Jan 18, 2025

Uh oh!

jacksteamdev commented May 2, 2025

Uh oh!

netlify bot commented May 21, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented May 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

mikaello commented Jun 23, 2025

Uh oh!

fisker commented Jun 23, 2025 •

edited

Loading

Uh oh!

mikaello commented Jun 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

byplayer commented Sep 7, 2024 • edited by fisker Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

barcell1 commented Dec 20, 2024

Uh oh!

jacksteamdev left a comment

Choose a reason for hiding this comment

Uh oh!

jacksteamdev Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

byplayer Jan 18, 2025

Choose a reason for hiding this comment

Uh oh!

jacksteamdev commented May 2, 2025

Uh oh!

netlify bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for prettier ready!

Uh oh!

pkg-pr-new bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mikaello commented Jun 23, 2025

Uh oh!

fisker commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikaello commented Jun 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

byplayer commented Sep 7, 2024 •

edited by fisker

Loading

netlify bot commented May 21, 2025 •

edited

Loading

pkg-pr-new bot commented May 21, 2025 •

edited

Loading

fisker commented Jun 23, 2025 •

edited

Loading