-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add todo-list card #735
base: main
Are you sure you want to change the base?
Add todo-list card #735
Conversation
bdc3186
to
6882fc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🙂 I just left few comments
6882fc2
to
826fe3f
Compare
Thanks for taking the time! FYI I also added a link to the shopping list docs in the README.md |
826fe3f
to
ef4d94b
Compare
Rebased and resolved merge conflicts. |
@piitaya Can you share you thought on this? |
@lscheibel by any chance, can you create your own card with this look and feel? This proposal of yours is a huge improvement over the standard version and looks like it will never see the light of day. It would be a shame to lose your work, congratulations on the initiative 👌. |
@netsoft-ruidias Thanks for the kind words! Unfortunately, I won't get around to working on this for at least another month, but I should try it by then :) |
# Conflicts: # src/mushroom.ts
I think this PR is more relevant than ever since in HA 2023.11 they added a lot of stuff related to todo lists. |
@DannyFeliz That sounds great! I'll check what needs to be adjusted to make this work the new entity. |
I was busy so I haven't given any recent feedback on this PR. Only few comments :
|
2a94a11
to
6ac002a
Compare
6ac002a
to
fd08607
Compare
@piitaya I've updated the card to work with the new Feedback: Personally, I don't think the If you want I can add those, also without using the Here's an example of what the ha-checkbox would look like: Regarding the customizable icons, especially for the light theme, I personally much prefer the outlined checkboxes and would use those, while the defaults are chosen to fit the overall style the best. Nonetheless, I understand that mushroom tries to offer as few options as possible, so if this would block the merge of this PR, I'll remove them and maybe add a separate PR where this could be discussed. |
Is there any update on this topic? |
I can implement the new changes, namely support for descriptions and due dates and removal of the old shopping_list API, although I would need some form of feedback from @piitaya first. Next to the questions from my feedback above, I would like to ask how we'd go about rendering the markdown? I know that mushroom tries to be somewhat lean in its dependencies, so we could also render the markdown as plain text for now and make markdown support a different feature for the "maybe"-future. |
Description
I've added a new mushroom card as an alternative to the default shopping_list card offered by HA. It uses the common icon + title + state layout and displays its contents below. For the input I adopted the entity-control style even though the shopping-list is not really an entity I thought it looked quite nice. The editor allows to change common attributes like the name and layout but also what icons to use for the checked and unchecked state of items. This allows for some very minimal lists when used together with other themes.
(the misaligned checkboxes are a bug in webkit & blink and only appear in this preview.)

Related Issue
#734
Motivation and Context
This PR provides a visually pleasing card for the shopping_list integration.
How Has This Been Tested
All features which are implemented have been tested in Chrome, Safari and Firefox on a Mac machine.
Types of changes
Checklist