Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker config #353

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rv2931
Copy link

@rv2931 rv2931 commented Dec 4, 2024

Little updates and improvements for docker compose config

  • Fix: links are not supported (legacy for docker official, and not supported by podman). Replacing by common network + depends_on
  • Fix: version is obsolete: => remove version as this is no longer used by docker compose
  • Feat: replace static exposed port values for services by env vars + default values in docker compose file allowing overriding them via .env file
  • Add: .env.template file as model of env variables to customize exposed (UDATA_HTTP|REDIS|MONGODB|_EXPOSED_PORT) port in docker compose config. just copy this file to .env
  • Add: .gitignore to ignore:
    • .env: override env vars for docker-compose, can contains local and sensitive data wihtout being tracked by git
    • docker-compose.override.yml: override docker-compose config by local specific values/attributes wihtout being tracked by git
  • Feat: as it is a development stack using UDATA_SETTINGS & mounting a volume to share udata.cfg and making config change without being forced to rebuild image

@rv2931
Copy link
Author

rv2931 commented Dec 4, 2024

@Sorry my mistake, it was a merge targetted to my personnal fork. closing it
finally it can be usefull to integrate. I let you decide to integrate or not

@rv2931 rv2931 closed this Dec 4, 2024
@rv2931 rv2931 reopened this Dec 4, 2024
…id rebuild image for dev after config change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant