fix: download button pointing to an incorrect binary on Windows arm64 #7240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes nodejs#7239 This PR changes the way DownloadButton calculates `bitness` which gets passed to `getNodeDownloadUrl`. Previously, this value was passed directly from `useDetectOS()` without any further processing, leading to the issue mentioned above. After this change, `bitness` is calculated similarly to how it's done in `BitnessDropdown`, so: by passing `architecture` and `bitness` to `getUserBitnessByArchitecture`: https://github.com/nodejs/nodejs.org/blob/c5345f551ea545cf9d04017204b17f3099940ada/apps/site/components/Downloads/Release/BitnessDropdown.tsx#L16-L29 Signed-off-by: Wojciech Maj <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RedYetiDev
approved these changes
Nov 19, 2024
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
Is this reproducible locally? If not, I'll restart the CI to see if it was a flake? |
No there are no issue with prettier. The code format is just not right. @wojtekmaj could you do a |
araujogui
approved these changes
Nov 19, 2024
wojtekmaj
changed the title
|
Ah, sorry! I did that PR entirely on the go :D |
github-actions
bot
removed
the
github_actions:pull-request
|
No worries! Once all the checks pass, since this has approvals, I've added it to the merge queue |
bmuenzenmeyer
pushed a commit
that referenced
this pull request
Nov 21, 2024
…#7240) * Fix Download button pointing to an incorrect binary on Windows arm64 Closes #7239 This PR changes the way DownloadButton calculates `bitness` which gets passed to `getNodeDownloadUrl`. Previously, this value was passed directly from `useDetectOS()` without any further processing, leading to the issue mentioned above. After this change, `bitness` is calculated similarly to how it's done in `BitnessDropdown`, so: by passing `architecture` and `bitness` to `getUserBitnessByArchitecture`: https://github.com/nodejs/nodejs.org/blob/c5345f551ea545cf9d04017204b17f3099940ada/apps/site/components/Downloads/Release/BitnessDropdown.tsx#L16-L29 Signed-off-by: Wojciech Maj <[email protected]> * Fix formatting --------- Signed-off-by: Wojciech Maj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way
DownloadButtoncalculatesbitnesswhich gets passed togetNodeDownloadUrl.Previously, this value was passed directly from
useDetectOS(), leading to the issue mentioned in the original issue.After this change,
bitnessis calculated similarly to how it's done inBitnessDropdown, so: by passingarchitectureandbitnesstogetUserBitnessByArchitecture:nodejs.org/apps/site/components/Downloads/Release/BitnessDropdown.tsx
Lines 16 to 29 in c5345f5
Validation
See #7239 for reproduction steps.
I've validated the fix by navigating to Vercel preview (linked by a bot below) and verifying the binary link (see bottom left corner):
Related Issues
Closes #7239
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.