Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Save gifti with datatype None #4857

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

man-shu
Copy link
Contributor

@man-shu man-shu commented Dec 2, 2024

Changes proposed in this pull request:

  • use datatype None if data format is not recognized

Copy link
Contributor

github-actions bot commented Dec 2, 2024

👋 @man-shu Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.65%. Comparing base (087f713) to head (b780252).

Files with missing lines Patch % Lines
nilearn/surface/surface.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4857      +/-   ##
==========================================
- Coverage   93.66%   93.65%   -0.01%     
==========================================
  Files         136      136              
  Lines       17147    17148       +1     
  Branches     2962     2962              
==========================================
  Hits        16060    16060              
- Misses        577      578       +1     
  Partials      510      510              
Flag Coverage Δ
macos-latest_3.10_test_plotting 93.17% <0.00%> (-0.01%) ⬇️
macos-latest_3.11_test_plotting 93.17% <0.00%> (-0.01%) ⬇️
macos-latest_3.12_test_plotting 93.17% <0.00%> (-0.01%) ⬇️
macos-latest_3.13_test_plotting 93.17% <0.00%> (-0.01%) ⬇️
macos-latest_3.9_test_plotting 93.15% <0.00%> (-0.01%) ⬇️
ubuntu-latest_3.10_test_plotting 93.17% <0.00%> (-0.01%) ⬇️
ubuntu-latest_3.11_test_plotting 93.17% <0.00%> (-0.01%) ⬇️
ubuntu-latest_3.12_test_plotting 93.17% <0.00%> (-0.01%) ⬇️
ubuntu-latest_3.13_test_plotting 93.17% <0.00%> (-0.01%) ⬇️
ubuntu-latest_3.13_test_pre 93.18% <0.00%> (-0.01%) ⬇️
ubuntu-latest_3.9_test_min 69.33% <0.00%> (-0.01%) ⬇️
ubuntu-latest_3.9_test_plot_min 92.05% <0.00%> (-0.02%) ⬇️
ubuntu-latest_3.9_test_plotting 93.15% <0.00%> (-0.01%) ⬇️
windows-latest_3.10_test_plotting 93.15% <0.00%> (+<0.01%) ⬆️
windows-latest_3.11_test_plotting 93.15% <0.00%> (-0.01%) ⬇️
windows-latest_3.12_test_plotting 93.15% <0.00%> (-0.01%) ⬇️
windows-latest_3.13_test_plotting 93.15% <0.00%> (-0.01%) ⬇️
windows-latest_3.9_test_plotting 93.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@musicinmybrain
Copy link

I’m testing this on s390x. I should be able to report results tomorrow morning.

@musicinmybrain
Copy link

I tried this as a patch to 0.11.0, and it does not seem to have made a difference in the failing tests on s390x.

@musicinmybrain
Copy link

I tried this as a patch to 0.11.0, and it does not seem to have made a difference in the failing tests on s390x.

Stop the presses! I’m mistaken. The patch wasn’t actually applied. I need to try it again.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test is needed on this PR.

@man-shu man-shu marked this pull request as draft December 3, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Some new test failures on s390x (big-endian) in 0.11.0
3 participants