-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Save gifti with datatype None #4857
base: main
Are you sure you want to change the base?
Conversation
👋 @man-shu Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4857 +/- ##
==========================================
- Coverage 93.66% 93.65% -0.01%
==========================================
Files 136 136
Lines 17147 17148 +1
Branches 2962 2962
==========================================
Hits 16060 16060
- Misses 577 578 +1
Partials 510 510 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I’m testing this on s390x. I should be able to report results tomorrow morning. |
I tried this as a patch to 0.11.0, and it does not seem to have made a difference in the failing tests on |
Stop the presses! I’m mistaken. The patch wasn’t actually applied. I need to try it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test is needed on this PR.
Changes proposed in this pull request: