-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] release_docs workflow #4854
Conversation
👋 @man-shu Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4854 +/- ##
=======================================
Coverage 93.66% 93.66%
=======================================
Files 136 136
Lines 17147 17147
Branches 2962 2962
=======================================
Hits 16060 16060
Misses 577 577
Partials 510 510
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Update on my hypothesis for why the release docs workflow fails |
Will merge and test this on my fork see if this goes further. |
ok it is failing on my fork for other reasons. |
but there is a workflow dispatch on this workflow so we can trigger it manually on the upstream: https://github.com/nilearn/nilearn/actions/runs/12137153863 |
🤞🏽 |
get_data failed so I re ran it |
ok this is still failing I think we should try to see if we can modify our regular doc publishing workflow to do the trick |
Changes proposed in this pull request:
We get a permission denied error when we try to clone the
nilearn.github.io
repo in_build/nilearn.github.io
.I think it's because_build
directory does not yet exists, so create a_build
dir firstgit clone
can handle making a new directory if the specified cloning path does not exist. Now I think this happens because we are trying to do things in.
and we might not have permissions to create directory there. So now we do everything in~/