Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] release_docs workflow #4854

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Conversation

man-shu
Copy link
Contributor

@man-shu man-shu commented Dec 2, 2024

  • Closes none but tries to fix the release docs workflow

Changes proposed in this pull request:
We get a permission denied error when we try to clone the nilearn.github.io repo in _build/nilearn.github.io.

  • I think it's because _build directory does not yet exists, so create a _build dir first
  • it seems git clone can handle making a new directory if the specified cloning path does not exist. Now I think this happens because we are trying to do things in . and we might not have permissions to create directory there. So now we do everything in ~/

Copy link
Contributor

github-actions bot commented Dec 2, 2024

👋 @man-shu Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@man-shu
Copy link
Contributor Author

man-shu commented Dec 2, 2024

The error:
Screenshot 2024-12-02 at 3 43 34 PM

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.66%. Comparing base (087f713) to head (561f63e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4854   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files         136      136           
  Lines       17147    17147           
  Branches     2962     2962           
=======================================
  Hits        16060    16060           
  Misses        577      577           
  Partials      510      510           
Flag Coverage Δ
macos-latest_3.10_test_plotting 93.17% <ø> (ø)
macos-latest_3.11_test_plotting 93.17% <ø> (ø)
macos-latest_3.12_test_plotting 93.17% <ø> (ø)
macos-latest_3.13_test_plotting 93.17% <ø> (ø)
macos-latest_3.9_test_plotting 93.15% <ø> (ø)
ubuntu-latest_3.10_test_plotting 93.17% <ø> (ø)
ubuntu-latest_3.11_test_plotting 93.17% <ø> (ø)
ubuntu-latest_3.12_test_plotting 93.17% <ø> (ø)
ubuntu-latest_3.13_test_plotting 93.17% <ø> (ø)
ubuntu-latest_3.13_test_pre 93.19% <ø> (ø)
ubuntu-latest_3.9_test_min 69.34% <ø> (ø)
ubuntu-latest_3.9_test_plot_min 92.06% <ø> (ø)
ubuntu-latest_3.9_test_plotting 93.15% <ø> (ø)
windows-latest_3.10_test_plotting 93.15% <ø> (+<0.01%) ⬆️
windows-latest_3.11_test_plotting 93.15% <ø> (ø)
windows-latest_3.12_test_plotting 93.15% <ø> (ø)
windows-latest_3.13_test_plotting 93.15% <ø> (ø)
windows-latest_3.9_test_plotting 93.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@man-shu man-shu requested a review from Remi-Gau December 2, 2024 15:12
@man-shu
Copy link
Contributor Author

man-shu commented Dec 2, 2024

  • it seems git clone can handle making a new directory if the specified cloning path does not exist. Now I think this happens because we are trying to do things in . and we might not have permissions to create directory there. So now we do everything in ~/

Update on my hypothesis for why the release docs workflow fails

doc/Makefile Outdated Show resolved Hide resolved
doc/Makefile Outdated Show resolved Hide resolved
doc/Makefile Outdated Show resolved Hide resolved
@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Dec 3, 2024

Will merge and test this on my fork see if this goes further.

@Remi-Gau Remi-Gau merged commit e1c5514 into nilearn:main Dec 3, 2024
10 checks passed
@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Dec 3, 2024

ok it is failing on my fork for other reasons.

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Dec 3, 2024

but there is a workflow dispatch on this workflow so we can trigger it manually on the upstream: https://github.com/nilearn/nilearn/actions/runs/12137153863

@man-shu
Copy link
Contributor Author

man-shu commented Dec 3, 2024

🤞🏽

@man-shu
Copy link
Contributor Author

man-shu commented Dec 3, 2024

get_data failed so I re ran it

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Dec 3, 2024

ok this is still failing

I think we should try to see if we can modify our regular doc publishing workflow to do the trick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants