-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] update colormap example #4851
Conversation
trying to better match this page of the matploblib doc: https://matplotlib.org/stable/users/explain/colors/colormaps.html#overview |
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4851 +/- ##
==========================================
- Coverage 94.32% 94.32% -0.01%
==========================================
Files 143 143
Lines 18636 18630 -6
Branches 3105 3105
==========================================
- Hits 17578 17572 -6
Misses 548 548
Partials 510 510
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
HTML render of the colormap example (work in progress but feedback welcome) |
I don't really like this example: it simply repeats matplotlib with little Nilearn-specificity. Its is also very technical with local functions etc, and does not comprise detailed explanations nor insights into what should be used for what purpose. |
Any suggestions on how to then explain why the nilearn colormaps are better than the ones in matplotlib and how to guide user on how to choose amongst them ? |
Use colormaps on a simple image to give a critical view on the pros and cons of each ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
compared to the old one on stable: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The codecov failure is weird -- no lines are flagged
Yeah I was confused by that as well. |
Changes proposed in this pull request:
RdBu_r
(missed in a previous PR)bwr
colormap rather than provide our own