👋 @hndgzkn Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

• PR has an interpretable title.
• PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
• Code is PEP8-compliant (see our documentation on coding style)
• Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

• There is at least one unit test per new function / class (see our documentation on testing)
• The new feature is demoed in at least one relevant example.

For bug fixes:

• There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.66%. Comparing base (92a2248) to head (3d53ce2).
Report is 3 commits behind head on main.

@@           Coverage Diff           @@
##             main    #4849   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files         136      136           
  Lines       17169    17170    +1     
  Branches     2973     2973           
=======================================
+ Hits        16082    16083    +1     
  Misses        577      577           
  Partials      510      510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I think I'd be more comfortable if we had a test for this

Yes, I agree. I try to understand how to test it.

Shall I also update change log bug fix part?

Hi @Remi-Gau ,

Is there a way to create maps that contain positive and negative regions using nilearn._utils.data_gen.generate_maps?

Shall I also update change log bug fix part?

yes: I opened a PR to recreate the doc/changes/latest.rst file where you can update the changelod

Hi @Remi-Gau ,

Is there a way to create maps that contain positive and negative regions using nilearn._utils.data_gen.generate_maps?

no idea but if you need something that does it don't hesitate to create a new function for it

Ok, I try to understand how I can do it .

@hndgzkn

• I just realized that we have this PR that is related to yours: [FIX] Fixed two-sided threshold #4501

maybe have a look to make sure it does not interfere with yours

maybe have a look to make sure it does not interfere with yours

Thank you for sharing this PR, the discussion helps me understand a bit more on thresholding.

The issue that we address is different, however it can be the reason that I cannot create maps with positive and negative regions, or lose the values by thresholding. I need to understand how it works and how it should work. I'll be more explicit later :)

I'll be more explicit later :)

If you feel that some bits of the code could do with more comments / refactoring to help faster understanding, don't hesitate to open PR that just do that.

nilearn._utils.data_gen.generate_maps generates 3D+t data so I don't think that there can be a clear concept of positive/negative region.

@hndgzkn
should I finish #4501 and have you review it?