Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] use higher contrast pygment style for dark mode #4847

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Dec 1, 2024

  • Closes none

Changes proposed in this pull request:

  • use the monokai theme for rendering code in dark mode (higher contrast, comments more visible, better people with suboptimal vision)

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Dec 1, 2024

mode before after
light image image
dark image image

Copy link
Contributor

github-actions bot commented Dec 1, 2024

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.66%. Comparing base (92a2248) to head (f65b7e8).
Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4847   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files         136      136           
  Lines       17169    17169           
  Branches     2973     2973           
=======================================
  Hits        16082    16082           
  Misses        577      577           
  Partials      510      510           
Flag Coverage Δ
macos-latest_3.10_test_plotting 93.18% <ø> (+<0.01%) ⬆️
macos-latest_3.11_test_plotting 93.18% <ø> (ø)
macos-latest_3.12_test_plotting 93.18% <ø> (ø)
macos-latest_3.13_test_plotting ?
macos-latest_3.9_test_plotting 93.16% <ø> (ø)
ubuntu-latest_3.10_test_plotting 93.18% <ø> (ø)
ubuntu-latest_3.11_test_plotting 93.18% <ø> (ø)
ubuntu-latest_3.12_test_plotting 93.18% <ø> (ø)
ubuntu-latest_3.13_test_plotting 93.18% <ø> (ø)
ubuntu-latest_3.13_test_pre 93.20% <ø> (ø)
ubuntu-latest_3.9_test_min 69.31% <ø> (ø)
ubuntu-latest_3.9_test_plot_min 92.07% <ø> (ø)
ubuntu-latest_3.9_test_plotting 93.16% <ø> (ø)
windows-latest_3.10_test_plotting 93.16% <ø> (ø)
windows-latest_3.11_test_plotting 93.16% <ø> (ø)
windows-latest_3.12_test_plotting 93.16% <ø> (ø)
windows-latest_3.13_test_plotting 93.16% <ø> (ø)
windows-latest_3.9_test_plotting 93.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be checked also on white bg.

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Dec 2, 2024

To be checked also on white bg.

it will not be affected by this change: see first row of table here

@Remi-Gau Remi-Gau added Documentation for documentation related questions or requests User Experience labels Dec 2, 2024
@Remi-Gau Remi-Gau marked this pull request as ready for review December 2, 2024 12:32
@Remi-Gau Remi-Gau requested a review from man-shu December 3, 2024 13:41
@man-shu
Copy link
Contributor

man-shu commented Dec 3, 2024

I like monokai too!

@Remi-Gau Remi-Gau merged commit a0716f3 into nilearn:main Dec 3, 2024
34 checks passed
@Remi-Gau Remi-Gau deleted the doc/pygment_dark branch December 3, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation for documentation related questions or requests User Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants