Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] remove pre-commit related workflows #4775

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Remi-Gau
Copy link
Collaborator

Changes proposed in this pull request:

  • remove pre-commit workflows and let pre-commit CI handle them

Copy link
Contributor

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@Remi-Gau
Copy link
Collaborator Author

this is just to show what #4760 would entail

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.51%. Comparing base (abb80ff) to head (e1604c3).
Report is 291 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4775      +/-   ##
==========================================
+ Coverage   91.85%   93.51%   +1.65%     
==========================================
  Files         144      135       -9     
  Lines       16419    17089     +670     
  Branches     3434     2954     -480     
==========================================
+ Hits        15082    15980     +898     
+ Misses        792      599     -193     
+ Partials      545      510      -35     
Flag Coverage Δ
macos-latest_3.10_test_plotting 93.01% <ø> (?)
macos-latest_3.11_test_plotting 93.01% <ø> (+1.15%) ⬆️
macos-latest_3.12_test_plotting 93.01% <ø> (?)
macos-latest_3.13_test_plotting 93.01% <ø> (?)
macos-latest_3.9_test_plotting 92.98% <ø> (?)
ubuntu-latest_3.10_test_plotting 93.01% <ø> (+1.15%) ⬆️
ubuntu-latest_3.11_test_plotting 93.01% <ø> (?)
ubuntu-latest_3.12_test_plotting 93.01% <ø> (?)
ubuntu-latest_3.13_test_plotting 93.01% <ø> (?)
ubuntu-latest_3.13_test_pre 93.03% <ø> (?)
ubuntu-latest_3.9_test_min 68.95% <ø> (?)
ubuntu-latest_3.9_test_plot_min 91.89% <ø> (?)
ubuntu-latest_3.9_test_plotting 92.99% <ø> (?)
windows-latest_3.10_test_plotting 92.99% <ø> (?)
windows-latest_3.11_test_plotting 92.99% <ø> (?)
windows-latest_3.12_test_plotting 92.99% <ø> (?)
windows-latest_3.13_test_plotting 92.99% <ø> (?)
windows-latest_3.9_test_plotting 92.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use pre-commit CI to run checks and update hooks
1 participant