Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add graphql-middleware as a dependency to rate-limiter plugin #2330

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Add graphql-middleware as a dependency to rate-limiter plugin #2330

merged 3 commits into from
Nov 20, 2024

Conversation

enisdenjo
Copy link
Collaborator

It's an indirect peer dependency of graphql-rate-limit. graphql-middleware is a peer dependency of graphql-shield and graphql-shield is a dependency of graphql-rate-limit. Not having it causes dependency issues with end-users, like graphql-hive/gateway#149.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 9e18417

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/rate-limiter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@envelop/graphql-jit 8.0.4-alpha-20241120164858-9e1841786a0e8b859188aa7f339250903844afad npm ↗︎ unpkg ↗︎
@envelop/rate-limiter 6.2.1-alpha-20241120164858-9e1841786a0e8b859188aa7f339250903844afad npm ↗︎ unpkg ↗︎

@github-actions GitHub Actions
Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://efde27f2.envelop.pages.dev

@theguild-bot
Copy link
Collaborator

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 766140      ✗ 0     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: 100.00% ✓ 164680      ✗ 0     
     ✓ { mode:envelop-cache-jit }.......................: 100.00% ✓ 336936      ✗ 0     
     ✓ { mode:envelop-just-cache }......................: 100.00% ✓ 164596      ✗ 0     
     ✓ { mode:graphql-js }..............................: 100.00% ✓ 99928       ✗ 0     
     data_received......................................: 2.9 GB  24 MB/s
     data_sent..........................................: 167 MB  1.4 MB/s
     envelop_init.......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     envelop_total......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_context....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_execute....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_parse......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_validate...................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=2.87µs  min=1.24µs   med=2.61µs  max=4ms      p(90)=3.53µs  p(95)=3.92µs 
     http_req_connecting................................: avg=14ns    min=0s       med=0s      max=791.46µs p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=2.84ms  min=161.52µs med=2.75ms  max=39.27ms  p(90)=5.23ms  p(95)=6.08ms 
       { expected_response:true }.......................: avg=2.84ms  min=161.52µs med=2.75ms  max=39.27ms  p(90)=5.23ms  p(95)=6.08ms 
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=3.37ms  min=460.28µs med=3.02ms  max=17.53ms  p(90)=5.67ms  p(95)=6.21ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=1.47ms  min=161.52µs med=1.22ms  max=16.37ms  p(90)=2.46ms  p(95)=2.62ms 
     ✓ { mode:envelop-just-cache }......................: avg=3.36ms  min=390.26µs med=3ms     max=22.46ms  p(90)=5.64ms  p(95)=6.17ms 
     ✓ { mode:graphql-js }..............................: avg=5.72ms  min=888.25µs med=4.94ms  max=39.27ms  p(90)=9.58ms  p(95)=10.38ms
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 383070
     http_req_receiving.................................: avg=35.96µs min=12.78µs  med=31.39µs max=9.89ms   p(90)=48.16µs p(95)=51.88µs
     http_req_sending...................................: avg=12.98µs min=4.17µs   med=10.01µs max=11.12ms  p(90)=19.69µs p(95)=21.25µs
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=2.79ms  min=128.8µs  med=2.7ms   max=39.2ms   p(90)=5.17ms  p(95)=6.02ms 
     http_reqs..........................................: 383070  3192.169181/s
     iteration_duration.................................: avg=3.12ms  min=365.58µs med=3ms     max=39.94ms  p(90)=5.53ms  p(95)=6.37ms 
     iterations.........................................: 383070  3192.169181/s
     vus................................................: 10      min=10        max=10  
     vus_max............................................: 20      min=20        max=20

@ardatan ardatan merged commit b1210bc into main Nov 20, 2024
18 checks passed
@theguild-bot theguild-bot mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardatan ardatan Awaiting requested review from ardatan

@n1ru4l n1ru4l Awaiting requested review from n1ru4l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enisdenjo @theguild-bot @ardatan