Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JSON schema const keyword in OpenApiSchema #1943

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

MaggieKimani1
Copy link
Contributor

Fixes #1940

@@ -347,6 +352,7 @@
{
Title = schema?.Title ?? Title;
Id = schema?.Id ?? Id;
Const = schema?.Const ?? Const;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.
@@ -347,6 +352,7 @@
{
Title = schema?.Title ?? Title;
Id = schema?.Id ?? Id;
Const = schema?.Const ?? Const;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.
Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@MaggieKimani1 MaggieKimani1 merged commit 98b01e0 into vnext Nov 26, 2024
10 of 11 checks passed
@MaggieKimani1 MaggieKimani1 deleted the mk/add-json-schema-const-keyword branch November 26, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft.OpenApi v2 lacks support for const keyword in OpenApiSchema
2 participants