Support ES6 Map and Set in Serializer. With Tests.#965
Open
lincolnthree wants to merge 1 commit intolocalForage:masterfrom
Open
Support ES6 Map and Set in Serializer. With Tests.#965lincolnthree wants to merge 1 commit intolocalForage:masterfrom
lincolnthree wants to merge 1 commit intolocalForage:masterfrom
Conversation
Author
|
So, I haven't actually been able to run the tests yet since I can't seem to get the harness to run / tests can't find chrome, etc... Interested to see what the CI result is... |
lincolnthree
changed the title
Author
|
Nope, not sure what's wrong. |
Author
|
Possible I'm not using Map/Set correctly in the tests. |
Author
|
Can someone with the ability to run the test suite check this out? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-submission of #674 with test cases.