Skip to content

feat: report LIST_VOLUMES_PUBLISHED_NODES cap #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

feat: report LIST_VOLUMES_PUBLISHED_NODES cap #323

merged 1 commit into from
Dec 5, 2024

Conversation

guilhem
Copy link
Contributor

@guilhem guilhem commented Nov 25, 2024

Plugin already implements required calls
This enables https://github.com/kubernetes-csi/external-attacher/blob/master/README.md#periodic-re-sync

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@guilhem guilhem requested review from a team as code owners November 25, 2024 23:05
@guilhem guilhem mentioned this pull request Nov 25, 2024
Closed
10 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.57%. Comparing base (248c1fd) to head (8e19da8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage   76.56%   76.57%           
=======================================
  Files          22       22           
  Lines        2402     2403    +1     
=======================================
+ Hits         1839     1840    +1     
  Misses        458      458           
  Partials      105      105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

komer3
komer3 reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@komer3 komer3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we need to use/add --reconcile-sync to the csi driver manifest? Or the periodic resync will be enabled by default?

@guilhem
Copy link
Contributor Author

guilhem commented Nov 27, 2024

Would we need to use/add --reconcile-sync to the csi driver manifest? Or the periodic resync will be enabled by default?

each 1*min by default :)
https://github.com/kubernetes-csi/external-attacher/blob/43f4aa635290a95cc372c34689e99b37284619be/cmd/csi-attacher/main.go#L77

@guilhem guilhem force-pushed the list_volume_published_node branch from 7e6abfe to a4c9146 Compare November 28, 2024 12:47
@guilhem guilhem force-pushed the list_volume_published_node branch from a4c9146 to 8e19da8 Compare December 2, 2024 17:41
@guilhem guilhem merged commit 94b25fb into main Dec 5, 2024
7 checks passed
@guilhem guilhem deleted the list_volume_published_node branch December 5, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komer3 komer3 komer3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guilhem @komer3