Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kumactl): allow apply of an entire directory #8647

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(kumactl): allow apply of an entire directory #8647

wants to merge 1 commit into from

Conversation

lplazas
Copy link
Contributor

@lplazas lplazas commented Dec 17, 2023

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
    Apply Entire Directory using kumactl #8491
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lahabana
Copy link
Contributor

lahabana commented Feb 5, 2024

@lplazas thanks for the contrib and sorry it wasn't noticed earlier. Could you rebase it and make sure you sign-off your commit? Thanks!

@lplazas
Copy link
Contributor Author

lplazas commented Feb 6, 2024

Oh no worries, I am missing the tests but I was behind schedule on many things so I couldn't look into them. I'll rebase shortly and finish off the tests.

@michaelbeaumont
Copy link
Contributor

@lplazas just wanted to ping you on this, it'd be a great addition!

@lplazas
Copy link
Contributor Author

lplazas commented Aug 6, 2024

My bad I dropped the ball on this one, let me finish up the tests to wrap it up now that I have some spare time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lplazas @lahabana @michaelbeaumont