Drop Runtimes filter on LAVA Scheduler in Docker-compose deployment #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheduler is able to filter out Runtimes it will submit Jobs to with a "--runtimes" option. Even though the filter currently in use covers all the LAVA Runtimes available in the Pipeline config, using this filter may lead to missing some Job submissions in the future (if a new Runtime is not added to this list). This patch drops this option to fall back to the default behaviour which is submitting Jobs to all the Runtimes available in the Pipeline config. Docker-compose deployment is currently used on the Staging instance which limits its submissions by trigerring Jobs only on "kernelci" trees: https://github.com/kernelci/kernelci-pipeline/blob/54436dfff9786c4f5a827e94d8c9b7fe6fda12af/docker-compose.yaml#L147 Signed-off-by: Paweł Wieczorek <[email protected]>
pawiecz
force-pushed
the
drop-lava-runtimes-filtering-dc
branch
from
e5301c6
to
5c9a5a4
Compare
pawiecz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduler is able to filter out Runtimes it will submit Jobs to with a "--runtimes" option. Even though the filter currently in use covers all the LAVA Runtimes available in the Pipeline config, using this filter may lead to missing some Job submissions in the future (if a new Runtime is not added to this list).
This patch drops this option to fall back to the default behaviour which is submitting Jobs to all the Runtimes available in the Pipeline config.
Docker-compose deployment is currently used on the Staging instance which limits its submissions by trigerring Jobs only on "kernelci" trees:
kernelci-pipeline/docker-compose.yaml
Line 147 in 54436df