src/logspec_api: set code_culprit True #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helen-fornazier
force-pushed
the
logspec_culprit
branch
from
556f798
to
2130b0b
Compare
|
Successfully tested with a local instance of kernelci-pipeline submitted to KCIDB playgroud, see https://grafana.kernelci.org/d/issue/issue?var-version=0&var-id=maestro:bba672c389cd8e575694e468d87a80b1b4074241&var-datasource=edqupth5xi8e8b |
spbnick
requested changes
Dec 5, 2024
After reviewing the current version of logspec we are using, all the errors parsed are of type code, so set culprit_code: True Signed-off-by: Helen Koike <[email protected]>
helen-fornazier
force-pushed
the
logspec_culprit
branch
from
2130b0b
to
8eb725d
Compare
spbnick
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing the current version of logspec we are using, all the errors parsed are of type code, so set culprit_code: True