-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4l2-decoder: Remove media tree monitoring, add stable-rc_6.6 #897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK there is no such tree as stable-rc_6.6.
I added documentation for rules parameter: #899 if it will help.
stable-rc_6.6 is name of one of build configurations, it cannot be used in rules.
@denisyuji from my understanding, the codec tests are going to target the 6.6 LTS (and the 6.12 LTS later). As far as I can see we're not tracking the 6.6 LTS tree/branch at the moment (that's different from stable-rc). In that case, I think we should start tracking the |
Yes, here is example: #807 |
754f6e0
to
6f68acd
Compare
@laura-nao, @nuclearcat , thank you for your inputs. Please, see the changes now and let me know if it looks good now. |
fb3c9d5
to
4ba3c09
Compare
As per internal discussion, we will not monitor `media` branch for fluster/tast v4l2 decoder tests neither for ChromeOS or Debian rootfs. We will keep monitoring `next` branch for fluster tests for now and evaluate its value later. Signed-off-by: Denis Yuji Shimizu <[email protected]>
4ba3c09
to
1025349
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nuclearcat did you see the changes I suggested above? With this patch as-is, all Tast tests will run on mainline, stable and collabora-chromeos-kernel, not just the codec tests..which is not what we wanted. |
@denisyuji can you fix that please? |
Thank you @laura-nao . That makes sense. I fixed it in a new PR: #939 |
As per internal discussion (ref: https://issuetracker.google.com/issues/371638530 ), we will not monitor
media
branch for fluster/tast v4l2 decoder tests neither for ChromeOS or Debian rootfs. We will keep monitoringnext
branch for fluster tests for now and evaluate its value later. In addition, ChromeOS will stay instable-rc_6.6
and eventuallystable-rc_6.12
, so we will keep monitoring this branch.