Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4l2-decoder: Remove media tree monitoring, add stable-rc_6.6 #897

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

denisyuji
Copy link
Contributor

@denisyuji denisyuji commented Nov 19, 2024

As per internal discussion (ref: https://issuetracker.google.com/issues/371638530 ), we will not monitor media branch for fluster/tast v4l2 decoder tests neither for ChromeOS or Debian rootfs. We will keep monitoring next branch for fluster tests for now and evaluate its value later. In addition, ChromeOS will stay in stable-rc_6.6 and eventually stable-rc_6.12, so we will keep monitoring this branch.

Copy link
Member

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK there is no such tree as stable-rc_6.6.
I added documentation for rules parameter: #899 if it will help.
stable-rc_6.6 is name of one of build configurations, it cannot be used in rules.

@laura-nao
Copy link
Contributor

@denisyuji from my understanding, the codec tests are going to target the 6.6 LTS (and the 6.12 LTS later).

As far as I can see we're not tracking the 6.6 LTS tree/branch at the moment (that's different from stable-rc). In that case, I think we should start tracking the linux-6.6.y branch of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git . That can be done by adding the URL to the trees: section of the pipeline.yaml file, and then adding a stable_6.6 build configuration to track the linux-6.6.y branch (similar to what has been done for stable-rc).
I think that should be enough to start tracking the 6.6 LTS in KernelCI, right @nuclearcat ?

@nuclearcat nuclearcat added the staging-skip Don't test automatically on staging.kernelci.org label Nov 19, 2024
@nuclearcat
Copy link
Member

Yes, here is example: #807

@denisyuji denisyuji changed the title v4l2-decoder: Remove media tree monitoring, add stable-rc_6.6 [WIP] v4l2-decoder: Remove media tree monitoring, add stable-rc_6.6 Nov 26, 2024
@denisyuji denisyuji changed the title [WIP] v4l2-decoder: Remove media tree monitoring, add stable-rc_6.6 v4l2-decoder: Remove media tree monitoring, add stable-rc_6.6 Dec 1, 2024
@denisyuji
Copy link
Contributor Author

@laura-nao, @nuclearcat , thank you for your inputs. Please, see the changes now and let me know if it looks good now.

@denisyuji denisyuji force-pushed the v4l2-decoder-update-trees branch 4 times, most recently from fb3c9d5 to 4ba3c09 Compare December 1, 2024 22:52
As per internal discussion, we will not monitor `media` branch
for fluster/tast v4l2 decoder tests neither for ChromeOS or
Debian rootfs. We will keep monitoring `next` branch for fluster
tests for now and evaluate its value later.

Signed-off-by: Denis Yuji Shimizu <[email protected]>
Copy link
Member

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nuclearcat nuclearcat added this pull request to the merge queue Dec 3, 2024
Merged via the queue into kernelci:main with commit 9ce925a Dec 3, 2024
3 checks passed
@laura-nao
Copy link
Contributor

@nuclearcat did you see the changes I suggested above? With this patch as-is, all Tast tests will run on mainline, stable and collabora-chromeos-kernel, not just the codec tests..which is not what we wanted.
I believe we should keep Tast tests running on mainline and stable-rc by default and change the behavior for codec tests only.

@nuclearcat
Copy link
Member

@denisyuji can you fix that please?

@denisyuji
Copy link
Contributor Author

Thank you @laura-nao . That makes sense. I fixed it in a new PR: #939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-skip Don't test automatically on staging.kernelci.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants