Fix copy ctor of ParserOptions (default implementation doesn't deep c…

…lone record type fields) (sebastienros#436)
ikvm · Feb 19, 2024 · 4661614 · 4661614
1 parent d0938c3
commit 4661614
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 0 deletions.
diff --git a/src/Esprima/ParserOptions.cs b/src/Esprima/ParserOptions.cs
@@ -14,6 +14,15 @@ public record class ParserOptions
 
     public ScannerOptions GetScannerOptions() => _scannerOptions;
 
+    protected ParserOptions(ParserOptions original)
+    {
+        _scannerOptions = original._scannerOptions with { };
+        Tokens = original.Tokens;
+        AllowReturnOutsideFunction = original.AllowReturnOutsideFunction;
+        MaxAssignmentDepth = original.MaxAssignmentDepth;
+        OnNodeCreated = original.OnNodeCreated;
+    }
+
     /// <summary>
     /// Gets or sets whether the tokens are included in the parsed tree, defaults to <see langword="false"/>.
     /// </summary>

diff --git a/test/Esprima.Tests/ParserOptionsTests.cs b/test/Esprima.Tests/ParserOptionsTests.cs
@@ -0,0 +1,26 @@
+namespace Esprima.Tests;
+
+public class ParserOptionsTests
+{
+    [Fact]
+    public void CopyCtorShouldCreateDeepClone()
+    {
+        var options1 = new ParserOptions { Tolerant = false };
+        var options2 = options1 with { Tolerant = true };
+
+        Assert.NotSame(options1.GetScannerOptions(), options2.GetScannerOptions());
+        Assert.True(options2.Tolerant);
+        Assert.False(options1.Tolerant);
+    }
+
+    [Fact]
+    public void EqualsShouldCheckStructuralEquality()
+    {
+        var options1 = new ParserOptions { Tolerant = false };
+        var options2 = options1 with { Tolerant = false };
+
+        Assert.NotSame(options1.GetScannerOptions(), options2.GetScannerOptions());
+        Assert.Equal(options1.GetScannerOptions(), options2.GetScannerOptions());
+        Assert.Equal(options1, options2);
+    }
+}