Use WithRequestLimit with 0 to skip rate limit
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice one |
VojtechVitek
requested changes
Sep 19, 2024
Comment on lines
+18
to
+21
| func getIncrement(ctx context.Context) (int, bool) { | ||
| value, ok := ctx.Value(incrementKey).(int) | ||
| return value, ok | ||
| } |
There was a problem hiding this comment.
on no ctx key, we should by default return 1
There was a problem hiding this comment.
I do it in the only place where this is used: https://github.com/klaidliadon/httprate/blob/ac748ea5a6b8921aef7a442985c77657a989932f/limiter.go#L90-L97
increment, ok := getIncrement(r.Context())
if !ok {
increment = 1
}
// If the increment is 0, we do not limit
if increment == 0 {
return false
}| } | ||
| // If the limit is set to 0, we are always over limit | ||
| if limit == 0 { | ||
| return true |
There was a problem hiding this comment.
we should be sending some headers back
X-RateLimit-Limit: 0
X-RateLimit-Remaining: 0
| } | ||
| // If the increment is 0, we are always on limit | ||
| if increment == 0 { | ||
| return false |
There was a problem hiding this comment.
we should set X-RateLimit-Increment: 0
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability of skipping rate limit by specifying 0