Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport][ipa-4-9] ipatests: Fixes for ipa-idrange-fix testsuite #7608

Closed
wants to merge 2 commits into from
Closed

[Backport][ipa-4-9] ipatests: Fixes for ipa-idrange-fix testsuite #7608

wants to merge 2 commits into from

Conversation

menonsudhir
Copy link
Contributor

This PR was opened automatically because PR #7548 was pushed to master and backport to ipa-4-9 is required.

@flo-renaud
Copy link
Contributor

Hi @menonsudhir
Can you split your commit into 2 different ones, one for the nightly definitions and the other for the test file? This way it's easier for the RHEL maintainers as the nightly definitions aren't part of RHEL source code.

The nightly definitions already have a job for test_ipa_idrange_fix, you should update the existing definition instead of adding a new one.

@flo-renaud flo-renaud self-assigned this Nov 28, 2024
@menonsudhir
Copy link
Contributor Author

Hi @menonsudhir Can you split your commit into 2 different ones, one for the nightly definitions and the other for the test file? This way it's easier for the RHEL maintainers as the nightly definitions aren't part of RHEL source code.

The nightly definitions already have a job for test_ipa_idrange_fix, you should update the existing definition instead of adding a new one.

@flo-renaud thank you for the review . Added the changes

@flo-renaud
Copy link
Contributor

The issue with readthedocs and AzurePipeline.freeipa (Docs) is related to the new cryptography release (44.0.0).
I have a fix in progress in #7609 that will have to be backported to our active branches.

Apart from that, you need to also update nightly_ipa-4-9_previous.yaml. Please wait for 7609 to be merged and backported, then rebase your PR.

@flo-renaud
Copy link
Contributor

Hi @menonsudhir
PR #7610 has been merged in ipa-4-9 branch, please rebase

@menonsudhir
Update prci definitions for ipa-idrange-fix testsuite.
b704ceb 
Topology has been for nightly runs to *master_1repl
from *ipaserver

Signed-off-by: Sudhir Menon <[email protected]>
@menonsudhir
ipatests: Fixes for ipa-idrange-fix testsuite
11b59a8 
Signed-off-by: Sudhir Menon <[email protected]>
@flo-renaud
Copy link
Contributor

@menonsudhir
thanks for the update. You can remove the temp commit and I will ack when the CI completes

@flo-renaud
Copy link
Contributor

The webui unit test failure is a known issue on ipa-4-9 branch and can be ignored.

@flo-renaud flo-renaud added ack Pull Request approved, can be merged pushed Pull Request has already been pushed labels Dec 3, 2024
@flo-renaud
Copy link
Contributor

ipa-4-9:

  • 7120343 Update prci definitions for ipa-idrange-fix testsuite.
  • 2be97f5 ipatests: Fixes for ipa-idrange-fix testsuite

@flo-renaud flo-renaud closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flo-renaud flo-renaud

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@menonsudhir @flo-renaud