Remove overidden functions in ipaplatform/suse #7544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configuration follows Red Hat close enough
|
We have no way to verify that this isn't going to break other SUSE users. There is a FIXME "Implement after libexec move". Was that done? How would it have affected SELinux? Also, can you expanding the commit message the reasoning, like you have in the PR? And add a signed-off-by? restore_context returns nothing so pass is fine check_selinux_status could return False and would be in line with the current set_selinux_booleans set_selinux_booleans already returns False Otherwise I think we'd need to validate that SUSE works in SELinux enforcing mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the freeipa ansible module against openSUSE MicroOS returns the following error:
argument 'selinux_works' is of type <class 'str'> and we were unable to convert to bool: The value '' is not a valid boolean. Valid booleans include: '1', 1, 0, 'false', 'yes', 'true', 'off', 'n', 'y', 't', '0', 'no', 'on', 'f'"Issue arises from functions in SuseTaskNamespace overriding the following functions from RedHatTaskNamespace
Each function was simply a 'pass' resulting in an empty string being returned to 'selinux_works'
SELinux on openSUSE is configured similarly enough to Red Hat distros that these empty overrides are not needed.
Tested on MicroOS