Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test for passkey feature. #7264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Integration test for passkey feature. #7264

wants to merge 1 commit into from

Conversation

amore17
Copy link
Contributor

@amore17 amore17 commented Mar 7, 2024 •
edited
Loading

Integration test for passkey feature.
https://pagure.io/freeipa/issue/9261

@amore17 amore17 force-pushed the passkey-integration branch 17 times, most recently from c8ea433 to 89f636d Compare March 13, 2024 08:36
@amore17 amore17 changed the title WIP: Passkey integration WIP: Passkey integration Tests Mar 19, 2024
@amore17 amore17 force-pushed the passkey-integration branch 11 times, most recently from e224732 to 72e62e9 Compare September 10, 2024 05:07
@amore17 amore17 force-pushed the passkey-integration branch 4 times, most recently from 148594d to 17de92f Compare September 10, 2024 12:27
@amore17 amore17 changed the title WIP: Passkey integration Tests Integration test for passkey feature. Oct 16, 2024
@flo-renaud
Copy link
Contributor

Lint is failing with the following message:

************* Module ipatests.test_integration.test_passkey
ipatests/test_integration/test_passkey.py:89: [W0612(unused-variable), TestPasskey.test_passkey_register_ipa_user] Unused variable 'add_passkey')

Pycodestyle reports:

checking ./ipatests/test_integration/test_passkey.py
./ipatests/test_integration/test_passkey.py:31:1: E302 expected 2 blank lines, found 1

@amore17 amore17 force-pushed the passkey-integration branch 2 times, most recently from 24fd61d to 15c5adb Compare October 17, 2024 05:23
@amore17 amore17 added the needs review Pull Request is waiting for a review label Oct 17, 2024
flo-renaud
flo-renaud reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@flo-renaud flo-renaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amore17
Please find inline comments

ipatests/prci_definitions/nightly_latest.yaml Outdated Show resolved Hide resolved
ipatests/test_integration/test_passkey.py Outdated Show resolved Hide resolved
ipatests/test_integration/test_passkey.py Outdated Show resolved Hide resolved
ipatests/test_integration/test_passkey.py Outdated Show resolved Hide resolved
ipatests/test_integration/test_passkey.py Outdated Show resolved Hide resolved
ipatests/test_integration/test_passkey.py Outdated Show resolved Hide resolved
ipatests/test_integration/test_passkey.py Outdated Show resolved Hide resolved
ipatests/test_integration/test_passkey.py Show resolved Hide resolved
ipatests/test_integration/test_passkey.py Outdated Show resolved Hide resolved
ipatests/test_integration/test_passkey.py Outdated Show resolved Hide resolved
@amore17 amore17 force-pushed the passkey-integration branch 2 times, most recently from 300fe3c to ee9b8bb Compare October 17, 2024 12:17
@amore17 amore17 force-pushed the passkey-integration branch 2 times, most recently from 1ffb3c8 to d2f218c Compare October 22, 2024 13:23
@amore17
Integration test for passkey feature.
b5b8860 
Added integration test for passkey.

This test class covers the tests for Passkey feature using umockdev utility.
Using umockdev utility required files are generated with passkey input
using umockdev-record and stored in ipatests/test_integration/data/passkey_*
These files are required for umockdev-run.

https://pagure.io/freeipa/issue/9261

Signed-off-by: Anuja More <[email protected]>
@flo-renaud
Copy link
Contributor

Thanks for the PR, LGTM. ACK when CI completes

@flo-renaud flo-renaud added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Oct 25, 2024
@flo-renaud
Copy link
Contributor

Which branches do you want to backport to? Is ipa-4-12 enough?

@flo-renaud flo-renaud added the re-run Trigger a new run of PR-CI label Oct 25, 2024
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Oct 25, 2024
@amore17 amore17 added the ipa-4-12 Mark for backport to ipa 4.12 label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flo-renaud flo-renaud flo-renaud left review comments

Assignees
No one assigned
Labels
ack Pull Request approved, can be merged ipa-4-12 Mark for backport to ipa 4.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amore17 @flo-renaud @freeipa-pr-ci