Category field added in obligation (get, post, patch) #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhowmik94
force-pushed
the
feat/api/new-categoryField-obligation
branch
from
8fac33c
to
8a73421
Compare
|
@bhowmik94 you need to commit the updated doc files after the |
bhowmik94
force-pushed
the
feat/api/new-categoryField-obligation
branch
from
8a73421
to
f63fa1e
Compare
|
@bhowmik94 make sure to update the PR description when you are creating one. |
|
Tried adding curl -X 'PATCH' \
'http://localhost:8085/api/v1/obligations/my%20obligation' \
-H 'accept: application/json' \
-H 'Authorization: my.token' \
-H 'Content-Type: application/json' \
-d '{
"category": "Distribute"
}'The response is 200 {
"status": 200,
"data": [
{
"id": 1,
"topic": "",
"type": "",
"text": "",
"classification": "",
"modifications": false,
"comment": "",
"active": false,
"text_updatable": false,
"category": ""
}
],
"paginationmeta": {
"resource_count": 1
}
} |
|
@GMishx Kindly try the update request now. |
GMishx
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Please check the category value against the allowed values from the enums:"Distribution,Patent,Internal,Contractual,Export Control,General". Currently I can put any values in the field with a PATCH or a POST request.
Also, the export and import endpoints do not reflect this new field. Please fix it as well.
And please update the PR description!
bhowmik94
force-pushed
the
feat/api/new-categoryField-obligation
branch
from
65d5aaf
to
d41efe9
Compare
GMishx
requested changes
Oct 30, 2024
bhowmik94
force-pushed
the
feat/api/new-categoryField-obligation
branch
3 times, most recently
from
848453f
to
0f2da9e
Compare
Signed-off-by: deo002 <[email protected]> refactor(obligations): Make separate database tables for classification and type chore(deps): bump github.com/golang-jwt/jwt/v4 in the go_modules group Bumps the go_modules group with 1 update: [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt). Updates `github.com/golang-jwt/jwt/v4` from 4.5.0 to 4.5.1 - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v4.5.0...v4.5.1) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v4 dependency-type: direct:production dependency-group: go_modules ... Signed-off-by: dependabot[bot] <[email protected]> feat(obligation): category field added in obligation get, post, patch fix: obligation POST, PATCH fixed for category fix: resolve merge conflict feat: added staged changes for category
bhowmik94
force-pushed
the
feat/api/new-categoryField-obligation
branch
from
0f2da9e
to
83ed38e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add category field for obligation GET, POST, PATCH requests
Add category for obligation import & export requests
Validate the field values for the given enum types.
Fixes New field "Category" in obligations GET, PUT, POST #85
Submitter Checklist
References