Added reorder sort string, which sorts variables alphabetically. #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ial for pre-training and transfer learning.
|
|
for more information, see https://pre-commit.ci
b8raoult
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick summary:
Added another reordering option reorder="sort" which sorts the variables alphabetically to enable transfer learning for stretched grid.
Why, and what is the purpose?
During transfer learning of stretched-grid model, the cutout and the option adjust='all' functionality is used. This will result that the combined dataset (ds1 and ds2) will have their variable list sorted alphabetically. However, then the pretrained model
needs to follow this type of sorting. This implementation will reorder the variable list to sort them alphabetically, hence enabling transfer learning when use multiple datasets when using reorder='sort'.
I have done some test, and also created some units tests, but unsure on where to put LAM dataset in order to make the testing work. For now I will submit this as a draft PR, if unit test is needed I will also include them.