-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(structuredProps) Add frontend for managing structured props and filtering by them #12097
Merged
chriscollins3456
merged 10 commits into
datahub-project:master
from
chriscollins3456:cc--structured-props-frontend
Dec 11, 2024
Merged
feat(structuredProps) Add frontend for managing structured props and filtering by them #12097
chriscollins3456
merged 10 commits into
datahub-project:master
from
chriscollins3456:cc--structured-props-frontend
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanHolstien
approved these changes
Dec 11, 2024
asikowitz
approved these changes
Dec 11, 2024
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Dec 17, 2024
brock-acryl
pushed a commit
to brock-acryl/datahub
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devops
PR or Issue related to DataHub backend & deployment
pending-submitter-merge
product
PR or Issue related to the DataHub UI/UX
release-0.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes a few main objectives:
The UI for managing structured props is almost entirely new code. We have a new page that you can only get to if you have the manage or view privileges for structured properties. Here you can go through the flow of interacting with the structured properties that you have in your instance.
The functionality for filtering by structured properties in the UI required a few backend changes as well as the frontend. Namely, we now pass back an optional
entity
on facet metadata so we can display the property associated with a particular filter. Then there is related business logic in aggregation query builder to this change. Additionally, we need to request the specific structured properties that have the flag to be a filter turned on, and then request these facets specifically. There was some other logic that needed to change around requesting specific facets and still returning default facets for our main search call.The next PR will include all of the rest of the display preferences for structured properties.
Screenshots:

Checklist