Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable to show full title in lineage by default #12078

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ public CompletableFuture<AppConfig> get(final DataFetchingEnvironment environmen
visualConfig.setAppTitle(_visualConfiguration.getAppTitle());
}
visualConfig.setHideGlossary(_visualConfiguration.isHideGlossary());
visualConfig.setShowFullTitleInLineage(_visualConfiguration.isShowFullTitleInLineage());
}
if (_visualConfiguration != null && _visualConfiguration.getQueriesTab() != null) {
QueriesTabConfig queriesTabConfig = new QueriesTabConfig();
Expand Down
5 changes: 5 additions & 0 deletions datahub-graphql-core/src/main/resources/app.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,11 @@ type VisualConfig {
Configuration for search results
"""
searchResult: SearchResultsVisualConfig

"""
Show full title in lineage view by default
"""
showFullTitleInLineage: Boolean
}

"""
Expand Down
6 changes: 5 additions & 1 deletion datahub-web-react/src/app/lineage/LineageVizInsideZoom.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { SchemaField, SchemaFieldRef } from '../../types.generated';
import { useIsShowColumnsMode } from './utils/useIsShowColumnsMode';
import { LineageVizControls } from './controls/LineageVizControls';
import LineageVizRootSvg from './LineageVizRootSvg';
import { useAppConfig } from '../useAppConfig';

const ControlsDiv = styled.div`
display: flex;
Expand Down Expand Up @@ -65,12 +66,15 @@ export default function LineageVizInsideZoom({
fineGrainedMap,
refetchCenterNode,
}: Props) {
const appConfig = useAppConfig();
const showFullTitle = appConfig.config.visualConfig.showFullTitleInLineage;

const [collapsedColumnsNodes, setCollapsedColumnsNodes] = useState<Record<string, boolean>>({});
const [selectedField, setSelectedField] = useState<SchemaFieldRef | null>(null);
const [highlightedEdges, setHighlightedEdges] = useState<ColumnEdge[]>([]);
const [visibleColumnsByUrn, setVisibleColumnsByUrn] = useState<Record<string, Set<string>>>({});
const [columnsByUrn, setColumnsByUrn] = useState<Record<string, SchemaField[]>>({});
const [showExpandedTitles, setShowExpandedTitles] = useState(false);
const [showExpandedTitles, setShowExpandedTitles] = useState(showFullTitle ?? false);
const showColumns = useIsShowColumnsMode();

useEffect(() => {
Expand Down
1 change: 1 addition & 0 deletions datahub-web-react/src/graphql/app.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ query appConfig {
visualConfig {
logoUrl
faviconUrl
showFullTitleInLineage
queriesTab {
queriesTabResultSize
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,7 @@ public class VisualConfiguration {

/** Search result related configurations */
public SearchResultVisualConfig searchResult;

/** Boolean flag enabled shows the full title of an entity in lineage view by default */
public boolean showFullTitleInLineage;
}
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ visualConfig:
faviconUrl: ${REACT_APP_FAVICON_URL:/assets/icons/favicon.ico}
appTitle: ${REACT_APP_TITLE:}
hideGlossary: ${REACT_APP_HIDE_GLOSSARY:false}
showFullTitleInLineage: ${REACT_APP_SHOW_FULL_TITLE_IN_LINEAGE:false}
entityProfile:
# we only support default tab for domains right now. In order to implement for other entities, update React code
domainDefaultTab: ${DOMAIN_DEFAULT_TAB:} # set to DOCUMENTATION_TAB to show documentation tab first
Expand Down
Loading