Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): dereference errors #12034

Merged
merged 6 commits into from
Dec 12, 2024
Merged

fix(ui): dereference errors #12034

merged 6 commits into from
Dec 12, 2024

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Dec 4, 2024 •
edited
Loading

To avoid white screen of death on the UI

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Dec 4, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 4, 2024
chriscollins3456
chriscollins3456 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see any issues with this!

@anshbansal anshbansal merged commit 3d75605 into master Dec 12, 2024
39 of 40 checks passed
@anshbansal anshbansal deleted the ab-fix-null-dereference branch December 12, 2024 15:19
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@anshbansal @sleeperdeep
fix(ui): dereference errors (datahub-project#12034)
3934b4e
brock-acryl pushed a commit to brock-acryl/datahub that referenced this pull request Jan 30, 2025
@anshbansal @chakru-r
fix(ui): dereference errors (datahub-project#12034)
121402d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @chriscollins3456