[GSoC'24] Consensus annotation #8434
Conversation
…b` to advanced block in task creation
…b` to advanced block in task creation (cherry picked from commit df460ce)
…on form and set it's max value to 10
…nd stage to `validation`
…g action on Save button while saving them
… into consensus-job
|
|
||
| - Quality analytics page will now report job assignees from quality reports | ||
| instead of current job assignees | ||
| (<https://github.com/cvat-ai/cvat/pull/8123>) |
| @@ -0,0 +1,4 @@ | |||
| ### Added | |||
|
|
|||
| - Datumaro format now supports skeletons | |||
There was a problem hiding this comment.
Incorrect merge
Please, add correct changelog entry, describing what was implemented in this patch
| frameConflicts.forEach((qualityConflict: T) => { | ||
| const { type, serverID } = qualityConflict.annotationConflicts[0]; |
There was a problem hiding this comment.
Is there any reason to remove comments that was left in original function?
If not, please return them
cvat-core/src/api-implementation.ts
Outdated
|
|
||
| const params = fieldsToSnakeCase({ ...filter, sort: '-id' }); | ||
|
|
||
| const reportsData = await serverProxy.consensus.assignee_reports(params); |
There was a problem hiding this comment.
Please, use camelCase naming style on client. assignee_reports -> assigneeReports
| }, | ||
| }); | ||
|
|
||
| return response.data.results[0]; |
There was a problem hiding this comment.
Why we always take the first item from the list?
Why not the last one?
There was a problem hiding this comment.
This is being used for consensus settings and quality settings for a given filter. We would get a list containing a single element.
| import { useSelector } from 'react-redux'; | ||
| import { LoadingOutlined } from '@ant-design/icons'; |
There was a problem hiding this comment.
3rdparty imports should come before internal imports
| window.addEventListener('hashchange', () => { | ||
| const hash = getTabFromHash(); | ||
| setTab(hash); | ||
| }); |
There was a problem hiding this comment.
Any event listener should be destroyed in useEffect's return. Otherwise this is memory leak
There was a problem hiding this comment.
Like this. Correct?
return () => {
window.removeEventListener('hashchange', () => {
setTab(getTabFromHash());
});
}I guess I also make this change in cvat-ui/src/components/analytics-page/analytics-page.tsx
…to gsoc/consensus-feature
…erge_consensus_jobs
[GSoC'24] GSoC Consensus Feature
Hello @bsekachev, how would you suggest to proceed further on this? |
|
I have made changes to fix the rest of the reviews on which I haven't commented. |
…mmon `consensus/create` endpoint
…consensus_jobs
…to gsoc/consensus-feature
[GSoC'24] Update GSoC Consensus Feature
|
Motivation and context
Depends on #8283, #8401
Closes #7973
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Style
Tests