Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
When we use the
s3fs
mounter, even if multiple pods use the same volume, the driver will start a process for each of them to mount the volume. This is wasteful of resources and bad for management.How are we solving the problem?
The idea is that pods using the same volume need to share a mount process.
We currently solve this problem based on the CSI specification.
NodeStageVolume
will start a process to mount it to host's/var/lib/kubelet/plugins/kubernetes.io/csi/pv/<pvc>/globalmount
directory.NodePublishVolume
just needs to bind mount/var/lib/kubelet/plugins/kubernetes.io/csi/pv/<pvc>/globalmount
to/var/lib/kubelet/pods/<pod>/volumes/kubernetes.io~csi/<pvc>/mount
directory.NodeUnpublishVolume
only needs to unmount/var/lib/kubelet/pods/<pod>/volumes/kubernetes.io~csi/<pvc>/mount
.NodeUnstageVolume
will unmount the volume from/var/lib/kubelet/plugins/kubernetes.io/csi/pv/<pvc>/globalmount
directory.We made a significant change to the code to make it easier to perform similar optimizations for other mounters.
Additionally, according to the specification, we also consider scenarios for handling concurrent calls.
https://github.com/container-storage-interface/spec/blob/master/spec.md#concurrency